From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1VyMJpYQnGDiYQAAWB0awg (envelope-from ) for ; Wed, 12 May 2021 13:29:58 -0400 Received: by simark.ca (Postfix, from userid 112) id 8D2F11F11C; Wed, 12 May 2021 13:29:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0899C1E783 for ; Wed, 12 May 2021 13:29:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E85D3857C71; Wed, 12 May 2021 17:29:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5E85D3857C71 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620840597; bh=7haSIIRnrFFK9fjnxYldJKz3amZjbAEmMFh1L6v/s5U=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=eHbDEvx4WGscwdD/N3gX3FCIZSNs7Zqgo5qd09UlICXg5KkpZ1QnKKKGRv8TtU6LR xH6HGPDagv2S/O7tK1Ha7bFrU573sFrpAMOSa4ts9zTj3CYWuLDJJqvYb2MGshfxHc iqG0nUejJppfKL8UJtrUUhXxUF/pf11nOyy2mxqw= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 068E53857C52 for ; Wed, 12 May 2021 17:29:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 068E53857C52 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14CHTnbY032200 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 May 2021 13:29:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14CHTnbY032200 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 31E231E783; Wed, 12 May 2021 13:29:49 -0400 (EDT) Subject: Re: [PATCH v2] gdb: make gdbpy_parse_command_name return a unique_xmalloc_ptr To: Tom Tromey , Simon Marchi via Gdb-patches References: <20210323175546.3836508-1-simon.marchi@polymtl.ca> <20210323183846.3886585-1-simon.marchi@polymtl.ca> <87tuopopmg.fsf@tromey.com> Message-ID: Date: Wed, 12 May 2021 13:29:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87tuopopmg.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 12 May 2021 17:29:49 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-01 1:56 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> * python/python-internal.h (gdbpy_parse_command_name): Return > Simon> gdb::unique_xmalloc_ptr. > Simon> * python/py-cmd.c (gdbpy_parse_command_name): Likewise. > Simon> (cmdpy_init): Adjust. > Simon> * python/py-param.c (parmpy_init): Adjust. > Simon> (add_setshow_generic): Take gdb::unique_xmalloc_ptr, release it > Simon> when done. > > Looks good. > > Simon> + /* We (unfortunately) currently leak the command name. */ > Simon> + cmd_name.release (); > > I wonder if the issue here is that two copies would need to be made, > because add_setshow_* makes two commands. Exactly. It's the same as before my patch, the comment only documents what is happening. This is really low prio, so I do not intend to fix it. Simon