From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16353 invoked by alias); 17 Jan 2018 17:29:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16338 invoked by uid 89); 17 Jan 2018 17:29:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jan 2018 17:29:56 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w0HHTob2027740 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 17 Jan 2018 12:29:54 -0500 Received: by simark.ca (Postfix, from userid 112) id 3968C1E5B7; Wed, 17 Jan 2018 12:29:50 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 87BCD1E074; Wed, 17 Jan 2018 12:29:48 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 17 Jan 2018 17:29:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFA 4/6] Change dwarf2_cu::method_info to be a std::vector In-Reply-To: <87y3kwl84m.fsf@tromey.com> References: <20180106002621.21099-1-tom@tromey.com> <20180106002621.21099-5-tom@tromey.com> <32a00426-ccdd-858f-85d7-3a2faab54d7f@ericsson.com> <87y3kwl84m.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 17 Jan 2018 17:29:50 +0000 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00353.txt.bz2 On 2018-01-17 12:15, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> On 2018-01-05 07:26 PM, Tom Tromey wrote: >>> This changes the type of dwarf2_cu::method_info and fixes up the >>> uses. >>> In order to remove cleanups from process_full_comp_unit and >>> process_full_type_unit, psymtab_include_file_name also had to be >>> changed to avoid leaving dangling cleanups. > > Simon> That seems ok, but I don't completely understand what's > happening. > > Simon> Can you clarify how > process_full_comp_unit/process_full_type_unit are > Simon> related to psymtab_include_file_name? I don't see how the later > gets > Simon> called by the formers. > > The call chain looks like this: > > process_full_comp_unit > -> process_die > -> read_file_scope > -> handle_DW_AT_stmt_list > -> dwarf_decode_lines > -> psymtab_include_file_name > > What happened formerly is that process_full_comp_unit installed an > outer > cleanup, and then psymtab_include_file_name took advantage of that by > leaving some dangling cleanups. Ok, thanks for the clarification. The patch LGTM. Simon