Re: [PATCH 2/2] Allow check-mark to be changed for CLI

Eli Zaretskii
2025-05-16T16:10:40Z

> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
> Date: Fri, 16 May 2025 08:18:54 -0600
>
> >>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Tom Tromey <tromey@adacore.com>
> >> Date: Fri, 09 May 2025 14:18:51 -0600
> >> Cc: Tom Tromey <tromey@adacore.com>
> >>
> >> +/* Emoji check-mark. */
> >> +static std::string check_mark = "✓";
>
> Eli> Btw, if this is related to emoji display, shouldn't the default be
> Eli> U+2713 followed by U+FE0F VARIATION SELECTOR-16, to show the "emoji
> Eli> presentation" of the CHECK MARK character, if the terminal supports
> Eli> that? Or do too few terminals have such support?
>
> I tried this but this combination doesn't seem to change the display.

I think this might depend on the terminal. E.g., the display in Emacs
does change, at least here and with fonts I'm using for Emoji.

Anyway, just a minor comment, I don't think it's a serious issue.