From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9618 invoked by alias); 31 Oct 2017 14:27:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9605 invoked by uid 89); 31 Oct 2017 14:27:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Oct 2017 14:27:41 +0000 Received: from ESESSHC018.ericsson.se (Unknown_Domain [153.88.183.72]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 2C.42.03220.A5888F95; Tue, 31 Oct 2017 15:27:38 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.72) with Microsoft SMTP Server (TLS) id 14.3.352.0; Tue, 31 Oct 2017 15:27:37 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.61.28] (192.75.88.130) by AM3PR07MB308.eurprd07.prod.outlook.com (2a01:111:e400:881b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.4; Tue, 31 Oct 2017 14:27:36 +0000 Subject: Re: [PATCH 4/8] Remove regcache_descr::nr_raw_registers To: Yao Qi , References: <1509096702-12202-1-git-send-email-yao.qi@linaro.org> <1509096702-12202-5-git-send-email-yao.qi@linaro.org> From: Simon Marchi Message-ID: Date: Tue, 31 Oct 2017 14:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509096702-12202-5-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR06CA0059.namprd06.prod.outlook.com (2603:10b6:3:37::21) To AM3PR07MB308.eurprd07.prod.outlook.com (2a01:111:e400:881b::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc12cc43-7ad8-4a2c-58a1-08d5206b88a0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603199);SRVR:AM3PR07MB308; X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB308;3:09lQ567tU2WKlLS2ltKFkCVTdI7Yr3PLRmj4vHIZIyDav0/ccHQU6BIOsvy5tlah6mvczv891Bdo0cX9Q7DM9+h4dYFlfXt0NOQaMlFnZJacewknUakaD151DUaf8AE1YamfQyOWXV0I20qqugNKqgNt1f+a/KO9x/xg7IDGgLdoega88SZk0gFYDfW+vUeXRxlfiBT5qnypH2rIIe4aVAUt0CSc7rhrb/Tbw3kX+uftjqOzCsD3fLZxD0utdALH;25:+HSsOgwlQPaQBMD22hU44FcGfyVsYTmxfS3xJV6NGAi+N5mHyZGXUrSLQpTv8Wx+17bs+YG5Rb/mpzPAIEssxhR02MWY4RzUDDXEUFZTJtPA42nP9bkyr7ON58jmr9VXxAIzOC1GdNLBREzmgxv15BVrsykBCQ++P1HY9PWG8xkefvVEJN6yOlHikJcYjsQBGj8ogyayBFKIls5m6pJ94zJ05bvrK6soHqt/nX/NiFTx+GA2Mo7OY2NJY3H6PiOLR0eH/yvlbZ/l5DlAiHPMStssXlhCcdxrTCpaiv+SX3RaJghIidS+ZCLQChBQvRjNec9CVCNqD11R0u9gJoFiw17mErdYqivGv8YRF1zdty8=;31:TpKovCXuhhXwHS8KuSvwVtXooF1dXgUqtY5FWJFE9rY1UIO8698TVRt6f5V7ISPlVwBU9rWB4YoiHurUfB1bXwTphHHXwqppGJsNIUbGubNQqRrAVL6v/z+1ub9TER4oPlS/FZIfRMZLnBpB6vLkeegCUbIFlGAHRHy40atPIZmXKOwhWRTKIQz922AwCcN7Zt9ijWW6/2T1vcQ12DIxZFxOgTWFZzBQeTFBdrz7AlM= X-MS-TrafficTypeDiagnostic: AM3PR07MB308: X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB308;20:8ssFPTxg/KGLunuMtBiwH3wD6s6whLjlqcahidPDEOY431rE7jLv/CZL7Ct5ijRHb7J4fQt/zoKZO+rQb94mc+agTdy0qWlV/78tJUYy37mOiHLGq2cMSLRztvD48kmuzY18uUOdeiAEP+Qtf7g/nKQmNrrlZpC314/O9yIL4KGnBL86Uww2hJbPKoGgMofgO20qiBWll1nnL4FVSgJGXLuJki3Ep23ujjoLmeVJvHbQVBU2WAZ7p0BRaIyjciUfiSJffj8Qxhfqrb5L1gUjCqUQ0sBZ3Cq3nEcD+JeubgFHpk9tvUdklptrTvEdDFx23VkmghFq15kbumANShKx4MXQ3q5bMl0/OiHhL8wa6XCoVbm4ljFbJatcdxcaYB28xt+Dn6AeuaEnbWDd2rdYCiZG/GUMbvV+s+ZerJXk13ts52VdMmm5zzxHMgC9X0cX/4U78ShjD+ME60K0GB/olQMYAGJE8a0L7Jws6oa40Bjj4QYjdV3aMy6xcyoQhZ3B;4:5PzNFDWoAFmHada4vA8E3s0dAqzh2Q+JqPUcmJyhZpFFZkza3lLBPmQoUcux/p2RjDR27jR9c4rTEuGHlkjjNpHhjU8uu+hznLXVct0oI/ImQ8ZMBV1n9W+2fqeXwtBdOOHr4WUiL/prMgYb3aQ5HbiD/3qcY23XyPM9cmZUf/Z1zOGaKYxo7CmNBC2wdqqUnlAaLK+9p9nHBmC6gdMEBont9FWwjvcXUL5bx89PndFhL0WVJLH+Q3qX0cxVYB39DY5dSFmcTUNbC+yl/EpSyg== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(93001095)(3231020)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR07MB308;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR07MB308; X-Forefront-PRVS: 04772EA191 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(346002)(376002)(39860400002)(24454002)(199003)(377424004)(189002)(7736002)(478600001)(49976008)(68736007)(16526018)(47776003)(65956001)(305945005)(31686004)(66066001)(6486002)(4001150100001)(65826007)(86362001)(97736004)(6246003)(53936002)(25786009)(5660300001)(229853002)(39060400002)(2950100002)(31696002)(2906002)(316002)(6666003)(3846002)(101416001)(54356999)(76176999)(6116002)(64126003)(50986999)(53546010)(83506002)(65806001)(81156014)(81166006)(230700001)(8676002)(189998001)(16576012)(106356001)(58126008)(33646002)(8936002)(105586002)(36756003)(23676003)(50466002)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR07MB308;H:[142.133.61.28];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTNQUjA3TUIzMDg7MjM6WXhoa1JZcUZYWFgwcnptU3dsRmNTT25WVnFr?= =?utf-8?B?bmhkanRaU2c5TTNsVFhOQ1ZQdC9SeVVISThuNmdJTHhkcmlHb1BqcmNlRGUr?= =?utf-8?B?RFB4dWxRdlBnS3hnMHBVdjBkbXVxU0VIYWttSDY2dDl5Z0NsZmlINjljK1pq?= =?utf-8?B?dFUya1k2Yy9BbTJIREZPY2JRQ0d6Z0xZMVFWZGxJV0l5MWExc2c0OHM5U3hO?= =?utf-8?B?UmhiNE9aMnBkRHpZdFpXM0VMMlpFdDFHWmt2WjFxYnFCN211eGhvbW52ZW5H?= =?utf-8?B?K0pKb3poZ2NIMTJxWlBGRFN5WlhVdTNWZTNkVFV1TG9CQjNHNWN3NWVtK2Va?= =?utf-8?B?SEtrbVZPd0pnT2dHaERPdXR5c0hzRExaUnZIeTdGcStJZTJ4aEpuakJBZHJ0?= =?utf-8?B?bEgyWUVYa3d1VytQSWttTEZSUGZCdWcrTG8wbXZKdVNPOTZEL0JNZzZ0V0ZP?= =?utf-8?B?MnJvZ0VmUzRmNXV6cFFRRkRaWDVKTVpDQVRvTUpIZGhjK1hGNVNkZXJoNnpT?= =?utf-8?B?bktkQ3dQOTZ3QnVmRlYvNmFhNk9tdGdlVXlaYnZLamN4alg1RytyNFVUU3c0?= =?utf-8?B?VGswK2tNWFk1TzU1Y1BYbGZ4bzEzZDVNc0NhL0NVcG1FM2dWTWdVaGhsZm53?= =?utf-8?B?ckNFUmU1MjYwM2xBS0ZxV3NXTE5ESldYV2NRMnJXbjlyTytMb08wVktsS2ta?= =?utf-8?B?R09Mbkx0SnFMUHlFZ09tTGUrckp6QUF4VnUvclZ6YmpHTjRqUVJFYThKa3JU?= =?utf-8?B?UzJjR1RraEpxR0VRMkgrSHl5cGVnWmRYN0QxczZsYUgxS0JWSHVOLytyRCtt?= =?utf-8?B?aHozNWFFdTlzdENSVHFkN09PME84MDVFZy9IcnlwZHM3U0NHTW44TFc4bC8v?= =?utf-8?B?ekFBZGZPMndJMFJJemZ1OU9rY3hjZ25rTVo5LzIxYkI2QWthSkg1MFJCMVd5?= =?utf-8?B?NTZHSFpZQzdoNWt0VzJ4dDhlMlZNT2ttOThtVGJnR3RGVDBwVHVqeFEreVg4?= =?utf-8?B?MXBBT0FWUjlkYWVpdE1MU1ovdVJrRWNZTFZJZXR3T09NOHB4cGEwMFFQWTRo?= =?utf-8?B?dFRGS0FzYmtXc2UwT2oxNFlMMzBHZ01ZL21EcDV4UGVjU0IyRTl2NkJxTlBx?= =?utf-8?B?Q1ltWVp3M29tdjF3cG81WFFrQ0lvdjFheUxXS3ZHZE1DQ29KL2htV29FaU5O?= =?utf-8?B?UXFjaFEvSzRScElkc2xKUldHVWNaNnd6d1hXek4xNGFsaktjNjcvbkhWSisz?= =?utf-8?B?TFlQamFYMXB5WndMMGM4VTd3dzMyNDZQTmd1TC9SNlIxU296VmRNVU9Ud1k2?= =?utf-8?B?MDMraVZDaTFNN2J3aWtuS053em15eEllK0lGMDYwM3RqeFU4ZERDbHVXL3hW?= =?utf-8?B?b1NIbFJENDFDeG1meUIwd3pXTzEzMHFKY1NPR1h1VmRGSkhoL2dyd0NySG94?= =?utf-8?B?eVZiRW9KWXpoTC9tTjBsNFNYbkQ2SkpKRmZjVEpON0t2NCtHR3NqdjNTNkN0?= =?utf-8?B?LzNtYVp3R3l3ck80RHhDejc4UXpKd21TcVE5bTNkQUcxZ0p4REZYc0dLZ3pZ?= =?utf-8?B?Q2x6TDlJbXd5ZUF0N09xeWRyWFZodk1makNiaFRpVXY5bVVUUEZFbTF1UWMw?= =?utf-8?B?a0hRL1FnZzZRMStLbThYUjIvUEFyd29yWFI1Vlh0MmZ6NS9GMysyL1JwR0tP?= =?utf-8?B?Q3VPVitESzBFRXpEM3IzVHlNL3p4WE82c2l5ZUR5bXlLK0RXa3ptd1hOWXZw?= =?utf-8?B?SW9qRFNxMDJoZ0NZUms4T29HdjhhaFVZdTJBS09HWEJYSVluVlQ3UjFndmlJ?= =?utf-8?B?Q2U5bFdCWWV1K0QrL245UlpJMForV1pqZTYyWGx3QS9zVFFVZklXa1NxTEJn?= =?utf-8?Q?W/8+qHAXEwmNZHkUVQn8kleoXx7dTcV?= X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB308;6:XvHpOVqVyynVxhXwKQJqtfmVkXPSB78hQj1lScojKNmwFG4w4GE7/k1jkop+St+EP0pkLw1/EHYPnLy0kdvGvMlunoHRk2PEOzeb9Tn+tWByAbbzOY0PpLANw0Ku50hDXYc2nbdS6B3tS3ZSOpeQM2tEvcn6xgmxjg5443HMwdB8vcbYdx9LSYDWXzfvCdT7vi/bjX9YCMf2PNIhUeat3wk6icmD31Gm3e7ExZzeITHo3GPTHlb+URwOlI2au6T/djSsLyvovna3d6SXYsMaVOb167mt6W7gB7mR0u3NQ/H8icvmJLVmOBErjJCn6z/myiKkL0//mBKAhEWPJwmxBjnGOi3DzzM9MmLLIbkl5qc=;5:9Vi34LEP3fLJGmkN5O64RolD2kD6dh71oXw15RPcCfK9vI6sZ7aKSwCGC6QcDOuBhwITLlg3mJbrA6uhy80VsFNhLmwHMpu68zkNFql4QWW4YwE3Rw5u6s/rpjTu59KZIfbSf5mL0cj9C/86hxAR3HPvSdUG9HC+tLzluPGayZk=;24:2n3ozR/EXsBYtMb5YTnuQfJ/j3/o7xvv15DHgw7oXyI8w1y00NQX+F1JRWBIwncwPl/iQLgv4l6BCcPpDPTm1wpPNWertXIBnC8LwcgRRlQ=;7:54ULjEGmeh2tHar0uczw4VALGBjvuYsrccDmeXgjziyZaJYAM8HwgY73fq4Nw5k2/A4a1ujFpu6e4Ic+ZuTMPWjl1079qxnOIYWZnPW0vOdCzkG8hldo9ZWoWEX12bxYyYp3XvZ72ubdeDSPTruXpfpsvZJ6p5ipXwC0CNA/3eYQQyZXW+G+sMrVROdR3fUZlIMMNDMG0pUuX6bFBkL7P2Yglvzx5JfSS3/RTdWIqAjdYeD1+iQ/RkQqoi/SorDW SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2017 14:27:36.2500 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc12cc43-7ad8-4a2c-58a1-08d5206b88a0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR07MB308 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00927.txt.bz2 On 2017-10-27 05:31 AM, Yao Qi wrote: > struct regcache_descr has fields nr_raw_registers and gdbarch, and > nr_raw_registers can be got via gdbarch_num_regs (gdbarch), so it looks > nr_raw_registers is redundant. This patch removes it. I would suggest adding a num_regs method to regcache to wrap the call to gdbarch_num_regs, so that if we need to change that call, we have only one place to change. Otherwise, LGTM. Simon