From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77508 invoked by alias); 30 Nov 2016 12:08:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76725 invoked by uid 89); 30 Nov 2016 12:08:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=cagney X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 12:07:59 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C6A51804FC; Wed, 30 Nov 2016 12:07:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUC7vmQ029481; Wed, 30 Nov 2016 07:07:58 -0500 Subject: Re: [PATCH 17/22] Simplify ui-out level code To: Simon Marchi References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124152710.25007-17-simon.marchi@polymtl.ca> <2905e1fc-fd7a-59f9-950e-70e0a0ad096e@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 30 Nov 2016 12:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00976.txt.bz2 On 11/26/2016 04:39 PM, Simon Marchi wrote: > On 2016-11-24 13:42, Pedro Alves wrote: >> On 11/24/2016 03:27 PM, Simon Marchi wrote: >>> /* Discard the current level, return the discarded level's index. >> >> "return the..." is stale. > > Indeed, both for push_level and pop_level. > >>> specified after table_body and inside a list.")); >>> /* NOTE: cagney/2001-12-08: There was a check here to ensure >>> - that this code was only executed when uiout->level was >>> + that this code was only executed when uiout->level () was >>> greater than zero. That no longer applies - this code is run >>> before each table row tuple is started and at that point the >>> level is zero. */ >> >> This is talking about level zero. Should we just delete the whole >> comment? > > Yes, I think so. I don't like this kind of comment very much, since > they are not so relevant after some time. After 15 years, I think we > can assume whoever needed to see it has seen it. I removed it locally. > >>> @@ -906,11 +897,9 @@ ui_out_new (const struct ui_out_impl *impl, void >>> *data, >>> uiout->flags = flags; >>> uiout->table.flag = 0; >>> uiout->table.body_flag = 0; >>> - uiout->level = 0; >>> >>> - /* Create uiout->level 0, the default level. */ >>> - std::unique_ptr level (new ui_out_level >>> (ui_out_type_tuple)); >>> - uiout->levels.push_back (std::move (level)); >>> + /* Create uiout->level () 0, the default level. */ >>> + push_level (uiout, ui_out_type_tuple); >> >> level 0 again? > > Changed to: > > /* Create the ui-out level #1, the default level. */ Sounds good. Thanks, Pedro Alves