From: Luis Machado <lgustavo@codesourcery.com>
To: John Baldwin <jhb@FreeBSD.org>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Define an error function in the PPC simulator library.
Date: Thu, 13 Apr 2017 13:25:00 -0000 [thread overview]
Message-ID: <aba5ecb5-42f0-9d68-b990-9ae7c412e2e7@codesourcery.com> (raw)
In-Reply-To: <20170405163332.82109-1-jhb@FreeBSD.org>
On 04/05/2017 11:33 AM, John Baldwin wrote:
> Previously this used the error function from GDB directly when linked
> against GDB instead of the error method in the host callbacks
> structure. This was exposed via a link error when GDB was converted
> to C++. The error function invokes the error callback similar to
> sim_io_error.
>
There is another implementation of error (...) in sim/ppc/main.c and
sim/ppc/misc.c. Should those be kept as is or should we only use the new
function you're providing?
Also, i don't see error being implemented in the other sim backends. I
wonder if we should just use whatever is available (sim_io_error?)
instead of supplying our own ppc-specific version?
next prev parent reply other threads:[~2017-04-13 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 16:34 John Baldwin
2017-04-13 13:25 ` Luis Machado [this message]
2017-04-14 18:02 ` John Baldwin
2017-05-05 19:51 ` John Baldwin
2017-05-19 16:28 ` [PING] " John Baldwin
2017-06-06 17:49 ` John Baldwin
2017-06-23 6:39 ` Sebastian Huber
2017-09-04 14:19 ` Pedro Alves
2017-09-05 3:00 ` John Baldwin
2017-09-05 9:14 ` Pedro Alves
2017-09-05 11:46 ` John Baldwin
2017-09-05 19:38 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aba5ecb5-42f0-9d68-b990-9ae7c412e2e7@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox