Re: [PATCHv9 03/14] gdb: change 'if' to gdb_assert in update_dprintf_command_list

Andrew Burgess
2024-03-31T10:27:43Z

Andrew Burgess <aburgess@redhat.com> writes:

> I noticed in update_dprintf_command_list that we handle the case where
> the bp_dprintf style breakpoint doesn't have a format and args string.
>
> However, I don't believe such a situation is possible. The obvious
> approach certainly already catches this case:
>
> (gdb) dprintf main
> Format string required
>
> If it is possible to create a dprintf breakpoint without a format and
> args string then I think we should be catching this case and handling
> it at creation time, rather than having GDB just ignore the situation
> later on.
>
> And so, I propose that we change the 'if' that ignores the case where
> the format/args string is empty, and instead assert that we do always
> have a format/args string. The original code, that handled an empty
> format/args string has existed since commit e7e0cddfb0d4, which is
> when dprintf support was added to GDB.
>
> If I'm correct and this situation can't ever happen then there should
> be no user visible changes after this commit.

I've gone ahead and committed this patch.

Thanks,
Andrew