From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53293 invoked by alias); 22 Aug 2018 17:38:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53284 invoked by uid 89); 22 Aug 2018 17:38:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Aug 2018 17:38:13 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7MHc6Bm022535 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Aug 2018 13:38:11 -0400 Received: by simark.ca (Postfix, from userid 112) id BA78D1EB3B; Wed, 22 Aug 2018 13:38:06 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 6A8791E76F; Wed, 22 Aug 2018 13:38:04 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 22 Aug 2018 17:38:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Restore behavior of disabling address randomization by default on GDBserver In-Reply-To: <1ad11ede-9a61-5ead-921a-bf2c1c1a6358@redhat.com> References: <1534953958-13064-1-git-send-email-simon.marchi@ericsson.com> <1ad11ede-9a61-5ead-921a-bf2c1c1a6358@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00550.txt.bz2 On 2018-08-22 12:14, Pedro Alves wrote: > On 08/22/2018 05:05 PM, Simon Marchi wrote: >> Commit >> >> c12a508 ("Add client_state struct.") >> >> inadvertently changed the default behavior of GDBserver wrt address >> randomization. The old disable_randomization global variable was >> initialized to 1, whereas the corresponding field in the client_state >> structure is initialized to 0. >> >> This fixes >> >> make check TESTS="gdb.base/jit-simple.exp" >> RUNTESTFLAGS="--target_board=native-gdbserver" >> make check TESTS="gdb.base/execl-update-breakpoints.exp" >> RUNTESTFLAGS="--target_board=native-gdbserver" >> >> Note that the execl-update-breakpoints.exp would only fail on systems >> where the toolchain emits position-independent executables by default >> (otherwise the main executable position is never randomized, so the >> value of disable_randomization didn't matter). > > Thanks for fixing this! > > This is OK, but please double-check the patch/commit, since it > seems to include the same hunk twice. Kind of looks like > the fix diff made it to the commit log? Oops yes, it's because I use "git commit -v" and managed to include that diff in the commit message by mistake. Pushed with that fixed. Simon