From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124545 invoked by alias); 20 Nov 2019 16:51:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124477 invoked by uid 89); 20 Nov 2019 16:51:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_HTTP,RCVD_IN_SORBS_SOCKS,SPF_PASS autolearn=ham version=3.3.1 spammy=Hayward, H*r:192.168.15, hayward X-HELO: mail-qk1-f179.google.com Received: from mail-qk1-f179.google.com (HELO mail-qk1-f179.google.com) (209.85.222.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Nov 2019 16:51:14 +0000 Received: by mail-qk1-f179.google.com with SMTP id q70so338286qke.12 for ; Wed, 20 Nov 2019 08:51:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=15wkag8pLo8zv5y/U1hG11WcdUfZC4Tof961SP84Y5w=; b=WS5TINAfR0NR0e1vzz+GU/LCKLgR53j/TsjQ8bNgeQSRn/sLVzVG8h+BM7SsUGZ337 7imxsOjTfS3IyhtWBDCiRlauQzFSSOMN44R0+aqCouVo7YBDQTaFBErd22aGOvk4xBvQ LOxg7TwXgyxNrX7Q7qMLwCjwXcL8XjNaXl8tGNKAzm44sQwbDHiF9Rz5l6WVryz23LXn KL0sA0QeFFoM2clHqM/+DxU4seicvZwRpd+4P6WyJmVu4OfttWAKj0lxL/49wNSh14FG mYvhLJWtZmz7fUILDEkWWD+VETYIdqvDlNttHIFHeX/Fj2lVMMoIkccLAV53ZufKkUAa EIUA== Return-Path: Received: from [192.168.15.17] (201-43-8-90.dsl.telesp.net.br. [201.43.8.90]) by smtp.gmail.com with ESMTPSA id h12sm11995832qkh.123.2019.11.20.08.51.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Nov 2019 08:51:11 -0800 (PST) Subject: Re: [review v4] [AArch64, SVE] Improve target description check for SVE in gdbserver To: Alan Hayward , Simon Marchi , "gdb-patches\\@sourceware.org" Cc: nd References: <20191119151417.76C002816F@gnutoolchain-gerrit.osci.io> <2774AF7F-70C2-494E-93A1-90402900336E@arm.com> From: Luis Machado Message-ID: Date: Wed, 20 Nov 2019 16:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <2774AF7F-70C2-494E-93A1-90402900336E@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00623.txt.bz2 Alan, On 11/20/19 1:34 PM, Alan Hayward wrote: > (Gerrit appears not to be sending me account verification emails, so can’t review from there...) > > >> On 19 Nov 2019, at 15:14, Luis Machado (Code Review) wrote: >> >> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/690 >> ...................................................................... >> >> [AArch64, SVE] Improve target description check for SVE in gdbserver >> >> The current code checks for the presence of a SVE target description by >> comparing the number of registers. This is a bit fragile since the number >> of registers can change whenever we add new sets. Like PAC, for example. >> > > Yes, agreed. > >> If the comparison breaks, then we're left with SVE registers in the >> description, but gdbserver doesn't send the registers to GDB, which in >> turn displays stale information to the user. >> >> The following patch changes the check to use the SVE feature string instead, >> which hopefully should be more stable. > > My only concern here is if it’s possible to end up with a tdesc without the correct feature name. > If this was GDB connected to a not-gdbserver remote stub, then yes, I think that’s possible. > However, given this is gdbserver, I think it should always be correctly creating the tdesc with the feature names. We usually make the feature names standard. GDB is responsible for dictating the main required features anyway, so other tools will follow what GDB has set. Other optional features may be provided by proprietary debugging stubs as needed though. > > So, it’s an ok from me. > Thanks! I'll push it shortly. > Alan. > >> >> gdb/gdbserver/ChangeLog: >> >> 2019-11-18 Luis Machado >> >> * linux-aarch64-low.c (is_sve_tdesc): Check against target feature >> instead of register count. >> * tdesc.c (tdesc_contains_feature): New function. >> * tdesc.h (tdesc_contains_feature): New prototype. >> >> Signed-off-by: Luis Machado >> Change-Id: I28b782cb1677560ca9a06a1be442974b25aabae4 >> --- >> M gdb/gdbserver/linux-aarch64-low.c >> M gdb/gdbserver/tdesc.c >> M gdb/gdbserver/tdesc.h >> 3 files changed, 22 insertions(+), 1 deletion(-) >> >> >> >> diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c >> index 87a21a0..9e234e0 100644 >> --- a/gdb/gdbserver/linux-aarch64-low.c >> +++ b/gdb/gdbserver/linux-aarch64-low.c >> @@ -83,7 +83,7 @@ >> { >> struct regcache *regcache = get_thread_regcache (current_thread, 0); >> >> - return regcache->tdesc->reg_defs.size () == AARCH64_SVE_NUM_REGS; >> + return tdesc_contains_feature (regcache->tdesc, "org.gnu.gdb.aarch64.sve"); >> } >> >> static void >> diff --git a/gdb/gdbserver/tdesc.c b/gdb/gdbserver/tdesc.c >> index 92a0a60..817e69a 100644 >> --- a/gdb/gdbserver/tdesc.c >> +++ b/gdb/gdbserver/tdesc.c >> @@ -186,3 +186,19 @@ >> tdesc->features.emplace_back (new_feature); >> return new_feature; >> } >> + >> +/* See gdbsupport/tdesc.h. */ >> + >> +bool >> +tdesc_contains_feature (const target_desc *tdesc, const std::string &feature) >> +{ >> + gdb_assert (tdesc != nullptr); >> + >> + for (const tdesc_feature_up &f : tdesc->features) >> + { >> + if (f->name == feature) >> + return true; >> + } >> + >> + return false; >> +} >> diff --git a/gdb/gdbserver/tdesc.h b/gdb/gdbserver/tdesc.h >> index b93f53c..da21cda 100644 >> --- a/gdb/gdbserver/tdesc.h >> +++ b/gdb/gdbserver/tdesc.h >> @@ -93,4 +93,9 @@ >> >> const struct target_desc *current_target_desc (void); >> >> +/* Return true if TDESC contains the feature described by string FEATURE. >> + Return false otherwise. */ >> +bool tdesc_contains_feature (const target_desc *tdesc, >> + const std::string &feature); >> + >> #endif /* GDBSERVER_TDESC_H */ >> >> -- >> Gerrit-Project: binutils-gdb >> Gerrit-Branch: master >> Gerrit-Change-Id: I28b782cb1677560ca9a06a1be442974b25aabae4 >> Gerrit-Change-Number: 690 >> Gerrit-PatchSet: 4 >> Gerrit-Owner: Luis Machado >> Gerrit-Reviewer: Luis Machado >> Gerrit-CC: Simon Marchi >> Gerrit-MessageType: newpatchset >