Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Andrew Burgess <aburgess@redhat.com>,
	Simon Marchi <simon.marchi@efficios.com>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb/macrotab: catch exception and rethrow around splay_tree_foreach
Date: Wed, 28 Oct 2026 15:24:59 -0400	[thread overview]
Message-ID: <ab511e13-fab8-4e03-bee6-8dd723100c35@polymtl.ca> (raw)
In-Reply-To: <87mrrx7mmb.fsf@redhat.com>

On 10/28/26 1:37 PM, Andrew Burgess wrote:
>> @@ -974,28 +983,39 @@ macro_for_each (struct macro_table *table,
>>    datum.file = NULL;
> 
> Given you are modernising the code anyway, maybe NULL -> nullptr here?
> 
> But otherwise, this looks great.  The approach and implementation make
> sense to me.
> 
> Thanks for fixing this.
> 
> Approved-By: Andrew Burgess <aburgess@redhat.com>
> 
> Thanks,
> Andrew

Thanks, pushed with that changed.

I'm also thinking that we could swap the splay stree for std::map, it
would make things simpler.

Simon

  reply	other threads:[~2026-10-28 19:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 14:45 [PATCH 1/2] gdb/testsuite: fix max-completions regex in test_gdb_complete_cmd_multiple Simon Marchi
2026-10-26 14:45 ` [PATCH 2/2] gdb/macrotab: catch exception and rethrow around splay_tree_foreach Simon Marchi
2026-10-28 17:37   ` Andrew Burgess
2026-10-28 19:24     ` Simon Marchi [this message]
2026-10-28 17:21 ` [PATCH 1/2] gdb/testsuite: fix max-completions regex in test_gdb_complete_cmd_multiple Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab511e13-fab8-4e03-bee6-8dd723100c35@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox