From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33416 invoked by alias); 8 Feb 2017 23:52:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33399 invoked by uid 89); 8 Feb 2017 23:52:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=balls, H*f:sk:87inok7, H*i:sk:87inok7, H*MI:sk:87inok7 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Feb 2017 23:52:01 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 962BB2E6067; Wed, 8 Feb 2017 23:52:01 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v18NpwUH008484; Wed, 8 Feb 2017 18:51:59 -0500 Subject: Re: [RFA 1/5] Remove some ui_out-related cleanups from Python To: Tom Tromey References: <20170115134253.24018-1-tom@tromey.com> <20170115134253.24018-2-tom@tromey.com> <20170116113021.sar3yh5ivykpqmbw@ball> <87inok708e.fsf@tromey.com> Cc: Trevor Saunders , gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 08 Feb 2017 23:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87inok708e.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00209.txt.bz2 On 02/08/2017 11:04 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> One difficulty with putting such a thing at the top level is that > Pedro> gdb relies on gnulib headers (that exist under gdb/) while > Pedro> other toolchain components don't, yet, at least. > > gnulib should just be at top-level, but I realize that's a pain. > > Pedro> It probably does make sense to start with something simpler and > Pedro> upgrade when/if we find a need. OTOH, looks like the current patch > Pedro> doesn't have accessors for the wrapped value, so it seems like we'll > Pedro> at least need to be extend it in that direction in no time. > > I had forgotten about this code. I don't mind using it instead. Let's start with your version, and leave the door open. The version I have would need a bit of cleaning, re-checking if GCC's implementation changed meanwhile (ISTR there have been recent patches to address some DRs), check that it compiles against clang and older gcc's (4.8, etc.). I already have too many balls in the air ATM. > Pedro> Patch LGTM with Trevor's and Simon's nits addressed. > > I have that done locally, but I've just been waiting until your series > lands, so I can rebase. And then maybe the option stuff wouldn't be > needed anyway? I don't remember the details from your branch, I was > just waiting for the big rebase to find out. My series is all in master. I think we'll still need your patch, since I only touched ui_files. I haven't done anything with ui_out list/tuple building. Thanks, Pedro Alves