From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97008 invoked by alias); 14 Feb 2020 20:31:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96832 invoked by uid 89); 14 Feb 2020 20:31:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail.efficios.com Received: from mail.efficios.com (HELO mail.efficios.com) (167.114.26.124) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Feb 2020 20:31:06 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 83D2323C6BD; Fri, 14 Feb 2020 15:31:04 -0500 (EST) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id F9STNFRMWO-a; Fri, 14 Feb 2020 15:31:04 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 4568923C6BA; Fri, 14 Feb 2020 15:31:04 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 4568923C6BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1581712264; bh=Da1vwguulZj0397sI03s1DZp5mL6No+Tev4atfipoeo=; h=To:From:Message-ID:Date:MIME-Version; b=rLkbcU0AcJ6M7RArrF6tjWgA3X4aYSQzzOiNx5y1jGhWPgd6VxX+hUaYzEdBQUa4r FwgTkHammQd7VHt0DyKPvf1u7aMbJr/u1rdDQ2cvDvTXJojY9qtvfoY4IKzjyRQwiZ ea1m+JiDyZEGRKpdVv875Vb4rbkTw493aCJd9bSG4aBzm8bgP/Q8TtafHkTxv+UX24 jP2E+8lqsa/oHfC/Oi4KOsH4iKV50tOm4qzstggdDM3QEXhNztFpiaIoC8BNZV/Smn z6vJqERpu2ZfMIgR+7ajtpalu1sKfQj1bXs4TtQDTbGqn57/nLLLaxVmHwaQWfUiq7 o4LrOxw2wE4sQ== Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ENogAaa8UowC; Fri, 14 Feb 2020 15:31:04 -0500 (EST) Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) by mail.efficios.com (Postfix) with ESMTPSA id 0471323C724; Fri, 14 Feb 2020 15:31:03 -0500 (EST) Subject: Re: [PATCH 2/2] gdb: make gdbarch_displaced_step_copy_insn return an std::unique_ptr To: Pedro Alves , gdb-patches@sourceware.org References: <20200122151410.30012-1-simon.marchi@efficios.com> <20200122151410.30012-2-simon.marchi@efficios.com> From: Simon Marchi Message-ID: Date: Fri, 14 Feb 2020 20:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00584.txt.bz2 On 2020-02-14 2:48 p.m., Pedro Alves wrote: > BTW, when I see a bunch of std::unique_ptr > I wonder whether a footype_up typedef wouldn't make things > read a bit clearer. Personally I don't mind the explicit std::unique_ptr, unless we're starting to use containers of that type. I then prefer: std::vector over std::vector> But I also don't mind using a typedef either, even without using containers, so I'll do that change as a separate patch on top. Thanks for the review! Simon