From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77109 invoked by alias); 22 Nov 2017 20:05:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77099 invoked by uid 89); 22 Nov 2017 20:05:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Nov 2017 20:05:54 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vAMK5lPc008128 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Nov 2017 15:05:52 -0500 Received: by simark.ca (Postfix, from userid 112) id 3B6BA1E585; Wed, 22 Nov 2017 15:05:47 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id E41801E030; Wed, 22 Nov 2017 15:05:46 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 22 Nov 2017 20:05:00 -0000 From: Simon Marchi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Basic c++ification of varobj In-Reply-To: <33fb6307-b3ad-83c3-9f24-e644856d4171@redhat.com> References: <20171118214606.24468-1-simon.marchi@polymtl.ca> <20171118214606.24468-2-simon.marchi@polymtl.ca> <33fb6307-b3ad-83c3-9f24-e644856d4171@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 22 Nov 2017 20:05:47 +0000 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00512.txt.bz2 On 2017-11-22 05:44, Pedro Alves wrote: > On 11/18/2017 09:46 PM, Simon Marchi wrote: > >> /* Return the type of the value that's stored in VAR, >> diff --git a/gdb/varobj.h b/gdb/varobj.h >> index 0d4a537d7e..d09b99b7f2 100644 >> --- a/gdb/varobj.h >> +++ b/gdb/varobj.h >> @@ -89,6 +89,9 @@ struct varobj_dynamic; >> a particular object variable. */ >> struct varobj >> { >> + varobj (varobj_root *root_); > > explicit? Good idea, fixed locally.