From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by sourceware.org (Postfix) with ESMTPS id 99A3B386F800 for ; Tue, 19 May 2020 12:27:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 99A3B386F800 Received: by mail-qk1-x744.google.com with SMTP id n14so14650281qke.8 for ; Tue, 19 May 2020 05:27:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O0ERKM+08CnGkP6KzVCvQzTpJyPuKBSMmviimaFFhGg=; b=GfdwPdQrGvXOU2MzRVkjgRpbODI6+gDvELG+t5glgi0BjIs7i/bMb8UKT1R0DV7DQo MygqWqYKi2eolxe94jyMXmtwnCJfr1xElkl61atz36ZVvtotFcGoOAPwg42ARpwQaiuo WoDMJ+oqgR4hY6EZ2qjjzNQclfCrjxL7z38wXg/aTW4u7bRLCp/9npBVZUITK/mRQwax nIQoXvahwukCFN4sTJCMEKWjijoXm6odsTu4ck1QKtHfzUcnk+Dk9i0EMheS9WegL3MU R42JDS8kxXXxU58nMMkeR/1Xqc47v9kgBCNmck+6fG3pxl+sWMibnN3Lyi1DjnG8ytfc nxYA== X-Gm-Message-State: AOAM530XLdTnRVgmrdqlcjtL9GA1on1xrswcfS8EoHX2UPm7UnYm9Ejj 3DckpxCziOT7MXOEch+w3/1S0j9Xme4= X-Google-Smtp-Source: ABdhPJya0N67TS3S0oN4ClsE4Q+EixHxiOqf31moQucel5WYUDoEZIUad3UMAsr5yAoTQVOYk8vQ9A== X-Received: by 2002:a37:a747:: with SMTP id q68mr21342598qke.452.1589891262784; Tue, 19 May 2020 05:27:42 -0700 (PDT) Received: from [192.168.0.185] ([179.185.145.12]) by smtp.gmail.com with ESMTPSA id k138sm10693391qke.55.2020.05.19.05.27.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2020 05:27:41 -0700 (PDT) Subject: Re: [RFC][PATCH 0/6] Step program considering the source column information To: Hannes Domani , gdb-patches@sourceware.org References: <20200516172632.4803-1-ssbssa.ref@yahoo.de> <20200516172632.4803-1-ssbssa@yahoo.de> From: Luis Machado Message-ID: Date: Tue, 19 May 2020 09:27:38 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200516172632.4803-1-ssbssa@yahoo.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 12:27:45 -0000 On 5/16/20 2:26 PM, Hannes Domani via Gdb-patches wrote: > Basically, this implements the new commands nextc (nc) and stepc (sc), > which allow to step through the program until an instruction is reached, > that belongs to another source column (according to the debug information). > > The current column location is visualized in the frame info, and in the TUI. > > Also, the column information is added to 'maint info line-table' and the > python line table interface. > > Since the frame info output is different, this certainly breaks the > testsuite, so this column indicator needs a parameter to disable, but I > wasn't concerned about this yet. > > With the example code from PR25913, it looks like this: > > (gdb) start > Temporary breakpoint 2 at 0x40162d: file gdb-25911.c, line 4. > Starting program: C:\src\tests\gdb-25911.exe > > Temporary breakpoint 2, main () at gdb-25911.c:4 > 4 int a = 4; > ^ > (gdb) nc > 6 a = 5; a = 6; a = 7; > ^ > (gdb) nc > 6 a = 5; a = 6; a = 7; > ^ > (gdb) nc > 6 a = 5; a = 6; a = 7; > ^ > (gdb) nc > 8 return 0; > > > What do you think of this so far? > > > [PATCH 1/6] Add column information of dwarf to the symbol information > [PATCH 2/6] Implement nextc and stepc commands (PR gdb/25913) > [PATCH 3/6] Add column information to maint info line-table > [PATCH 4/6] Add LineTableEntry.column to python line table interface > [PATCH 5/6] Show column of current execution point in frame info (PR > [PATCH 6/6] Show column of current execution point in TUI > Thanks for working on this, it is really useful. I'm guessing this series would probably handle the following situation very well: https://sourceware.org/bugzilla/show_bug.cgi?id=21221