From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 72FCC3858D35 for ; Sat, 30 May 2020 15:07:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 72FCC3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0882B1E791; Sat, 30 May 2020 11:07:20 -0400 (EDT) Subject: Re: [PATCH] hurd: unwinding support over signal trampolines To: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org References: <20200529230049.jmsn5nincf2453jy@function> From: Simon Marchi Message-ID: Date: Sat, 30 May 2020 11:07:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200529230049.jmsn5nincf2453jy@function> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 15:07:22 -0000 On 2020-05-29 7:00 p.m., Samuel Thibault wrote: > gdb/ChangeLog: > > 2020-05-29 Samuel Thibault > > * i386-gnu-tdep.c: Include "gdbcore.h" > (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays. > (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL, > I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros > (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p, > i386_gnu_sigcontext_addr): New functions > (i386gnu_init_abi): Register i386_gnu_sigtramp_p, > i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch > tdep. Please add a commit message. It should at least explain why this change is needed / desirable (what case isn't working, what functionality is missing) and what it does to address that (not in terms of which functions are added / removed, but how the GDB behavior changes as a consequence of that change). If the "how" is complex, it's always good to include some notes about that to help those who aren't experts of the system you work on. Simon