[PATCH v2 7/8] Remove aop_last

Tom Tromey
2023-06-20T17:37:24Z

aop_last is only used for an assertion. However, due to the '.def'
construct in the sources, this assert could never plausibly trigger
(the assert predates the use of a .def file here). This patch removes
the constant and the assert.
---
gdb/ax-general.c | 6 ------
gdb/ax.h | 1 -
2 files changed, 7 deletions(-)

diff --git a/gdb/ax-general.c b/gdb/ax-general.c
index a8451d71b2e..4ace2b490c0 100644
--- a/gdb/ax-general.c
+++ b/gdb/ax-general.c
@@ -349,12 +349,6 @@ ax_print (struct ui_file *f, struct agent_expr *x)
}
gdb_printf (f, _("\n"));

- /* Check the size of the name array against the number of entries in
- the enum, to catch additions that people didn't sync. */
- if ((sizeof (aop_map) / sizeof (aop_map[0]))
- != aop_last)
- error (_("GDB bug: ax-general.c (ax_print): opcode map out of sync"));
-
for (i = 0; i < x->buf.size ();)
{
enum agent_op op = (enum agent_op) x->buf[i];
diff --git a/gdb/ax.h b/gdb/ax.h
index 1fdecb2f9e5..e02aa7104ea 100644
--- a/gdb/ax.h
+++ b/gdb/ax.h
@@ -154,7 +154,6 @@ enum agent_op
aop_ ## NAME = VALUE,
#include "gdbsupport/ax.def"
#undef DEFOP
- aop_last
};
\f

--
2.39.2