Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ezra Sitorus <ezra.sitorus@arm.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: <gdb-patches@sourceware.org>, <luis.machado.foss@gmail.com>,
	<thiago.bauermann@linaro.org>
Subject: Re: [PATCH v3 6/6] gdb/doc: Document AArch64 FPMR support
Date: Wed, 22 Oct 2025 10:25:17 +0100	[thread overview]
Message-ID: <aPii_WJ5IddrDSL1@D2G2X7XGD1> (raw)
In-Reply-To: <86ikg8w9mg.fsf@gnu.org>

Hi Eli,

On Tue, Oct 21, 2025 at 11:35:51AM -0400, Eli Zaretskii wrote:
> > --- a/gdb/doc/gdb.texinfo
> > +++ b/gdb/doc/gdb.texinfo
> > @@ -27080,6 +27080,26 @@ Program received signal SIGSEGV, Segmentation fault
> >  Guarded Control Stack error.
> >  @end smallexample
> >  
> > +@subsubsection AArch64 Floating Point Mode Register
> > +@cindex Floating Point Mode Register, AArch64
> > +@cindex FPMR, AArch64
> 
> Index entries should preferably not us upper-case letters, so that
> their sorting does not depend on locale-specific rules.  So please use
> upper-case letters only in acronyms.
> 

I don't mind changing it to lowercase, but the other AArch64 entries use upper case
as well, e.g.

@subsubsection AArch64 Memory Tagging Extension
@cindex Memory Tagging Extension, AArch64
@cindex MTE, AArch64

> > +When @value{GDBN} is debugging the AArch64 architecture and the Floating Point
> > +Mode Register (FPMR) is available, then @value{GDBN} will make the @code{fpmr}
> > +available. This register determines the behaviour of FP8 instructions.
>             ^^
> Our conventions are to leave two spaces between sentences (it looks
> better in print).
> 

Yep, forgot about this one! I'll wait for comments on the other patches before sending
the fix for this.

> > @itemize @minus
> > @item
> > @samp{fpmr}, the tag control register.  It is represented as if it were a 64-bit
> > register with a custom flags type.
> > @end itemize

I've also noticed that there is an error here from copy-and-paste. It should be floating
mode register.

Ezra

  reply	other threads:[~2025-10-22  9:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 15:02 [PATCH v3 0/6] gdb/aarch64: Support for FPMR Ezra.Sitorus
2025-10-21 15:02 ` [PATCH v3 1/6] gdb/aarch64: Enable FPMR for AArch64 in gdb on Linux Ezra.Sitorus
2025-10-27 22:32   ` Luis
2025-10-21 15:02 ` [PATCH v3 2/6] gdbserver/aarch64: Enable FPMR for AArch64 in gdbserver " Ezra.Sitorus
2025-10-27 22:26   ` Luis
2025-10-21 15:02 ` [PATCH v3 3/6] gdb/aarch64: signal frame support for fpmr Ezra.Sitorus
2025-10-27 22:25   ` Luis
2025-10-21 15:02 ` [PATCH v3 4/6] gdb/aarch64: core file support for FPMR Ezra.Sitorus
2025-10-27 22:23   ` Luis
2025-10-21 15:02 ` [PATCH v3 5/6] gdb/aarch64: Tests " Ezra.Sitorus
2025-10-27 22:19   ` Luis
2025-10-21 15:03 ` [PATCH v3 6/6] gdb/doc: Document AArch64 FPMR support Ezra.Sitorus
2025-10-21 15:35   ` Eli Zaretskii
2025-10-22  9:25     ` Ezra Sitorus [this message]
2025-10-22 11:53       ` Eli Zaretskii
2025-10-27 22:08   ` Luis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPii_WJ5IddrDSL1@D2G2X7XGD1 \
    --to=ezra.sitorus@arm.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado.foss@gmail.com \
    --cc=thiago.bauermann@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox