From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id G3ATJDd4EGi1kAsAWB0awg (envelope-from ) for ; Tue, 29 Apr 2025 02:56:55 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=crRQ6kcG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 832691E10E; Tue, 29 Apr 2025 02:56:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0326B1E0C2 for ; Tue, 29 Apr 2025 02:56:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EAAD93858417 for ; Tue, 29 Apr 2025 06:56:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EAAD93858417 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=crRQ6kcG Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 50CDD3858C60 for ; Tue, 29 Apr 2025 06:54:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50CDD3858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50CDD3858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745909689; cv=none; b=rmfQyRykNL0AP5GbVDNviclEcvs75+2h2FHmfSOXfsE1jrlBQbPQyzV2NrN4FDxcNKkmkAzbbS/MEpdhZoj3fBCQCUybSqqxq7I8UH7xCG9wkxfHuzrLdHjthpy1I/6EUfG86BsTw5b5lEwC/kiELSJ/gpXfPoHkhNd1DmycavM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745909689; c=relaxed/simple; bh=pUMnkwdyO3j1chxZHAPJGF0IIAPdom1bqXa6OmMxkUU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=QbgnsG4rx2P9alkPkoblw6X0S2mP/51M/t822YzHiz3VtjejDIN0t3esWaCG1/Lm/2rZ0C+UI3m4gv3GoBlO4YBsB1S2xVPS36uyUnhJaT6EQ/CGiZIXC6F6ByPpnqySxsFyh5AUTHx2byi0YyuLJ5JXA09BeDZ7NT1tFBKqnpM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50CDD3858C60 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-22423adf751so56366995ad.2 for ; Mon, 28 Apr 2025 23:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1745909688; x=1746514488; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/YQP/Uq9Mi9KMt6jHwgBVKQLme+dcOG53HWvVMBEk1I=; b=crRQ6kcGGWsgi9B2c87A23B8D2q/TPtb5XAGH9i9MLQ+WqiTR9/rjinkYtTeOjJMzt Qhy9IXqaAmFbGD3CJuz/1hCJThoEz7SR2lHSEbXk76vRvdTsMtbBoLgTn44Ebib26Umd jCpnE/qbiMhZ8QOlF2rXwv0Gypx+gDW9f5/8Lb3CR0UmMU9As7VkY8VTh/g9xRtZYHuz 8DYKmEP/q3bV/1pzz8DJkdYnpOncOKnAAX9lIokgAc0Nct2VKA96ogpgsT/sGzWlQAyg fqeuiHDTDAG7haf/bjngVG+TMOqyEzHDFvP/SRmbB/acSVtTckUuEbqC5BCXnDt2V86J QDkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745909688; x=1746514488; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/YQP/Uq9Mi9KMt6jHwgBVKQLme+dcOG53HWvVMBEk1I=; b=C3xNYTy6Hsjj5Tm54prd0x2qhLrUVvN04EpvBfznXii9mpFeDMyX/a2qaWT2GBaaNA WP9rRSKTt6fxsUMAhHJCAiJOA1J1cnw6L9pAAYiR+GrvqMHAcbbkE7J0E/d+EXqci2xQ u+RWERVsDNcX/dKTE0ORx7vUKmTKWFviuKPLX+MrEUKVJV8W8KeZqLzFUxXaB2adcDXE XHzn86PhiG5wXkYhhGoCyJae8drce7PMCCCrhPk1c2G1d1UUdv0oxjYlQC+wsVIdc06a 5RPTQKlr8kr6g+6GQl+Konc2KRV/PH0U2yWJ7xNY4ABBaApUq/hgbM4KmmpECiMhWfdd 3AXw== X-Forwarded-Encrypted: i=1; AJvYcCVKIYAmx9jum6xVF8MU6BHGR4N7vqpKKKbEc7/6YnMTrLjog7vdye2KiKSF8LjYV3+EVHbv/Qc+tMOv8w==@sourceware.org X-Gm-Message-State: AOJu0Yyc9m5N94P9T+0CnJu3n5VoE4CuGqlFnbZZjfNIAkXcgSCCpgZN eRlU+d9sOdAc5b8rlBNoSBoNTqY6WCiRRZVpYv5ZXIy0wBFwE3enYwPO3m8a0j0wcMztnQ35qvg p4+M= X-Gm-Gg: ASbGnctlzUe+XtQ8qA3543J6KKFW9T8x8x9h859XSuVhbcVWnCZCRr0adRcQ7L/Zp/9 Sb+8qeIC+vfSc0R39m3Ok8jspFckBQ+R81ImNA98e6KUxsykc+B1PS06NTq/jG9JcTEm57q7gA+ sqr4hW+5jv5vFUOn5USw/8GUk4kMUWSh1DcZxSo8/S7+qtRxWBW4+hflIRqwZGv8oxvhX77dwsb of64dsOMftcDJhcC4bHq1x6Q+3lvf577YpehLt85ZHacIkFI3Hdaqx/iZ/2HyzdoRVBH6UPOw07 TTmu466F40MDYOrI7WD+94kHLYRu/jxtsrFV X-Google-Smtp-Source: AGHT+IG2UFXRXtHkKiLLWm2bD0v/3C9etUdspvB/j2W8Q6bfd0NN6I+/rPvxkY/4Jkqz2IP86MV9+Q== X-Received: by 2002:a17:903:18c:b0:220:ca39:d453 with SMTP id d9443c01a7336-22de6ea038cmr26789915ad.17.1745909688388; Mon, 28 Apr 2025 23:54:48 -0700 (PDT) Received: from ghost ([2601:647:6700:64d0:7ed0:3ded:7f7f:60b5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4d77ee3sm95213165ad.2.2025.04.28.23.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 23:54:47 -0700 (PDT) Date: Mon, 28 Apr 2025 23:54:45 -0700 From: Charlie Jenkins To: Andrew Burgess Cc: snatu@whileone.in, gdb-patches@sourceware.org Subject: Re: [PATCH] [PATCH v3] RISC-V: support for vector register accesses via ptrace() in RISC-V Linux native Message-ID: References: <20250424121915.1203050-2-snatu@whileone.in> <87msc06wi7.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, Apr 28, 2025 at 12:35:27PM -0700, Charlie Jenkins wrote: > On Mon, Apr 28, 2025 at 06:12:16PM +0100, Andrew Burgess wrote: > > Charlie Jenkins writes: > > > > > On Thu, Apr 24, 2025 at 12:19:14PM +0000, snatu@whileone.in wrote: > > >> From: Sameer Natu > > >> > > >> A v3 re-spin of the original patch. > > >> Tested with latest kernel 6.14.2 on RISCV QEMU. > > >> Removed Magic Numbers from v2 patch and worked on review comments of v2 patch. > > > > > > Thanks for working on this! > > > > > > Can you add a co-developed-by tag for the original author? > > > > > > You also don't need to have [PATCH] twice in the header! > > > > > > There are a handful of erroneous spaces at the end of lines. > > > > > > I tested this patch and I noticed that the vector instructions are not > > > being decoded. > > > > > > Breakpoint 1, vector () at main.S:4 > > > 4 vsetvli t0, a0, e32, m4, ta, ma > > > 1: x/i $pc > > > => 0x55555555566c : .insn 4, 0x0d2572d > > > > Does an `objdump` built from the same tree decode these instructions? > > Wondering if this is a problem with the objdump disassembler library, or > > a problem with the way GDB uses that library. > > Yes, `objdump -d` from the same tree dumps the instruction. Perhaps some > entry needs to be added to `riscv_gdbarch_init()` in gdb/riscv-tdep.c? This isn't relevant for this patch so we can worry about this later :). - Charlie > > - Charlie > > > > > Thanks, > > Andrew > >