From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id btIgMwB4DGhASQYAWB0awg (envelope-from ) for ; Sat, 26 Apr 2025 02:06:56 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=BOUqoZUK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C295F1E10E; Sat, 26 Apr 2025 02:06:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 985EA1E0C2 for ; Sat, 26 Apr 2025 02:06:55 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 039EB3857B9F for ; Sat, 26 Apr 2025 06:06:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 039EB3857B9F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=BOUqoZUK Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 19B403858D38 for ; Sat, 26 Apr 2025 06:06:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19B403858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 19B403858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745647582; cv=none; b=oJnYIZKKfqUkf8BQIuPQNwmCLLhMBZA8eLxYTz2VNdhAxI8osYE90iM7Ti6Vu7cD16SY3K1u0vkn6wSduhfz6TffCnV8XuPW/DhERF15pO1IQjd3RBHIJABrcrV2+hzO+h+iEfkYgCwXCqaJf6OV12s7oglI4O28NTACzXfC9jY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745647582; c=relaxed/simple; bh=ha+SoKJG56FrrmW45BjHguZ/RQz8amHUydhyHgD7F3M=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=vSWdSCsXJAq/aitru0VXSAFqcF1wZ+HLzf7kx5/6H4UcjaF/3KT6ZRWW9V2sanNK+T+RwXCZKwlzLOwHfl7HaOtTJOgnsEtSzYfdWgSXRqRY9C+HCwXNT5lFFGa8v1lEZgSSqM4/dRzBMAp864NTsL1UBcshZVQ4d3rAvswNYtw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 19B403858D38 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-227b828de00so33369985ad.1 for ; Fri, 25 Apr 2025 23:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1745647581; x=1746252381; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MXhaAQ7fHPcfLRFv6OrtGx+LoecI1TlmxEqM+sVD11Q=; b=BOUqoZUKBsgnARFKntaVGdyNs+9iX5FUYmLWAkVRo2XJckP8KUqWIlv0xtN/I5L+19 xSmnxP1Dvx1g8M7nvpmzuhCegs2il6Iox5sBqS0aavxU9lqwXrt63GFdvIFMskc3v4uJ 2Ch5BCxQo5igcFty9OvytM0y19j/rVLsY+FpaYXj7DdkHaz1+rWcZIhfL62UZpfZt+Wv 5uRJrGUqfufw6Bqvcx3F9NJFMN83atBntK8IWooAIExAVlAAtWTesl7vQWUBn1jIuiAp ZQp1VfHhb3j5aKJZJ3uGFrzrbQC4wkN2c4mJOlku27kEkFNJhArPm8moKp51dYjVD2dS T3cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745647581; x=1746252381; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MXhaAQ7fHPcfLRFv6OrtGx+LoecI1TlmxEqM+sVD11Q=; b=n9aGdJPlnf2rY4BntjNiiy102z6YxzV0ZlvNF5RrKyNk2DhdsifN7mPzcUxPat1Rsy MTauzLdbF33iEDIs7V+JkprhNUh0gkn35WU/66WDQDMPywSQS2ShoHDvTI3CaFh/MMtt /C0oJ1mxBRZm56AUUK4BKSDSk3XO2pKpSoINPsP9VVeyL0YI/lTH9onHrZg++G3dFEc3 7q7SKpWGcM3mz/zaA1FbDRjpGTXqMUp7glj6Q8R7LsKTpGKI0hiFlTULd76Wy32Af9vM nY317wSsAaqdgpatWmrsB4aXXu8ozUwKWpDVU1OWh7jhnl3cIQCsFA75lkg3W1yZLXej gjuw== X-Gm-Message-State: AOJu0YyltlvKKegHoOFrenLxF4A7DZ2ywfvb1WWi7AaKaWh6ojeLs7SY qILqqupPacf6D+SCEuUDe15EWlPZbre3KMpMRNSRN2zayNwr0vVBROU7udr1qMlS5xdHB2cpdjs T8Nk= X-Gm-Gg: ASbGncvTRfBP1Jvcx9d/oXa0FchlbITzWYhunH5Exdm3iVyqNHw7m/q1LgWICfYaeUe fEJxaX7MEuCs+sSBPSkPOX1YMQOYK2RO6CPmJmGyjxQ86xw9cHFX5uD0ueAPFdyJymDLN/d8bEj InEZ/7vLKU70NzGEznKJ4lqm/90Enva908n8TH4xUgTj9X9ENbbtFYSGC4c6X6kERCLv/bVGPah WoOx8GZkxmIND/eTUiBxkacF0boFGylbxRnUWnMjYYepT2sTlLd7mdk4gQ0/0viLLmU2cwyT8z6 CSWB/8YMHzJ2JL+2/UKpwEju/+C9YN0v1g3+5w== X-Google-Smtp-Source: AGHT+IEIL54BQAt8NhblcBrEDv5yaaPfI3vS0vRlr/pWqqijToc02v73tuKkYNY0YgG7Bt2yInalNA== X-Received: by 2002:a17:903:3c6b:b0:220:c4e8:3b9f with SMTP id d9443c01a7336-22dbf153b10mr79441445ad.0.1745647580948; Fri, 25 Apr 2025 23:06:20 -0700 (PDT) Received: from ghost ([2603:8000:713f:3d34:eff5:fcb9:11c6:8873]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db5100c13sm42812185ad.162.2025.04.25.23.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 23:06:20 -0700 (PDT) Date: Fri, 25 Apr 2025 23:06:18 -0700 From: Charlie Jenkins To: snatu@whileone.in, Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [PATCH v3] RISC-V: support for vector register accesses via ptrace() in RISC-V Linux native Message-ID: References: <20250424121915.1203050-2-snatu@whileone.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250424121915.1203050-2-snatu@whileone.in> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, Apr 24, 2025 at 12:19:14PM +0000, snatu@whileone.in wrote: > From: Sameer Natu > > A v3 re-spin of the original patch. > Tested with latest kernel 6.14.2 on RISCV QEMU. > Removed Magic Numbers from v2 patch and worked on review comments of v2 patch. Thanks for working on this! Can you add a co-developed-by tag for the original author? You also don't need to have [PATCH] twice in the header! There are a handful of erroneous spaces at the end of lines. I tested this patch and I noticed that the vector instructions are not being decoded. Breakpoint 1, vector () at main.S:4 4 vsetvli t0, a0, e32, m4, ta, ma 1: x/i $pc => 0x55555555566c : .insn 4, 0x0d2572d > > --- > gdb/arch/riscv.c | 188 ++++++++++++++++++++++++++++++++++- > gdb/nat/riscv-linux-tdesc.c | 68 +++++++++++++ > gdb/nat/riscv-linux-tdesc.h | 24 +++++ > gdb/riscv-linux-nat.c | 163 ++++++++++++++++++++++++++++++ > gdb/riscv-linux-tdep.c | 133 +++++++++++++++++++++++++ > gdb/riscv-tdep.c | 49 ++++++++- > gdb/riscv-tdep.h | 14 +++ > gdbserver/linux-riscv-low.cc | 110 ++++++++++++++++++++ > include/elf/common.h | 1 + > 9 files changed, 743 insertions(+), 7 deletions(-) > > diff --git a/gdb/arch/riscv.c b/gdb/arch/riscv.c > index a6188ea3a8c..14fc85631e3 100644 > --- a/gdb/arch/riscv.c > +++ b/gdb/arch/riscv.c > @@ -25,12 +25,38 @@ > #include "../features/riscv/64bit-fpu.c" > #include "../features/riscv/rv32e-xregs.c" > > +#include "opcode/riscv-opc.h" > + > #ifndef GDBSERVER > #define STATIC_IN_GDB static > #else > #define STATIC_IN_GDB > #endif > > +#ifdef GDBSERVER > +/* Work around issue where trying to include riscv-tdep.h (to get access to canonical RISCV_V0_REGNUM declaration > + from that header) is problamtic for gdbserver build. */ > +//#include "riscv-tdep.h" > +#define RISCV_VSTART 73 > +#define RISCV_VXSAT 74 > +#define RISCV_VXRM 75 > +#define RISCV_VCSR 80 > +#define RISCV_VL 3169 > +#define RISCV_VTYPE 3170 > +#define RISCV_VLENB 3171 > +#define RISCV_V0_REGNUM 4162 > +#else > +#include "riscv-tdep.h" > +#include "defs.h" > +#endif > + As Andrew said, it seems valid to delete these hard-coded addresses. > +static int > +create_feature_riscv_vector_from_features (struct target_desc *result, > + long regnum, > + const struct riscv_gdbarch_features > + features); > + > + > /* See arch/riscv.h. */ > > STATIC_IN_GDB target_desc_up > @@ -83,15 +109,169 @@ riscv_create_target_description (const struct riscv_gdbarch_features features) > else if (features.flen == 8) > regnum = create_feature_riscv_64bit_fpu (tdesc.get (), regnum); > > - /* Currently GDB only supports vector features coming from remote > - targets. We don't support creating vector features on native targets > - (yet). */ > if (features.vlen != 0) > - error (_("unable to create vector feature")); > + regnum = > + create_feature_riscv_vector_from_features (tdesc.get (), > + RISCV_V0_REGNUM, features); > After deleting the block, RISCV_V0_REGNUM can be replaced with regnum. - Charlie