From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81162 invoked by alias); 3 Nov 2017 16:46:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81126 invoked by uid 89); 3 Nov 2017 16:46:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=hadn't, There's, hadnt, Theres X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Nov 2017 16:46:33 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vA3GkQ0R022967 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 3 Nov 2017 12:46:31 -0400 Received: by simark.ca (Postfix, from userid 112) id 5F9731E533; Fri, 3 Nov 2017 12:46:26 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 6990B1E51C; Fri, 3 Nov 2017 12:46:15 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 03 Nov 2017 16:46:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 05/13] Remove directive-searched cleanups In-Reply-To: <87iner1fhd.fsf@tromey.com> References: <20171102223612.3642-1-tom@tromey.com> <20171102223612.3642-6-tom@tromey.com> <87iner1fhd.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 3 Nov 2017 16:46:26 +0000 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00081.txt.bz2 On 2017-11-03 12:42, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > >>> if (*excludep) >>> - { >>> - discard_cleanups (searched_cleanup); >>> - continue; >>> - } >>> + continue; > > Simon> In this case, the cleanup is discarded. Shouldn't the same > thing > Simon> happen with the scoped_restore? Or was it an error in the > original > Simon> code, and we always want to reset searched? > > Simon> There's the same case in d-namespace.c. > > I'm afraid I hadn't noticed this. Ouch. > > However, I think it has to be a latent bug, because it will result in > the using_direct's searched flag being permanently set -- nothing else > will ever clear it. > > Tom That's what my assumption was. From what I understand, we want to set the flag while we recurse and always restore it when we return. Simon