From: Simon Marchi <simark@simark.ca>
To: Guinevere Larsen <guinevere@redhat.com>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: fix bugs in gdb/copyright.py, make it use glob patterns
Date: Fri, 11 Apr 2025 11:28:08 -0400 [thread overview]
Message-ID: <a9bfb9f4-f9c0-4331-8e04-21c99e58466e@simark.ca> (raw)
In-Reply-To: <4a8030f1-34f2-4217-9711-413ba709d5e8@redhat.com>
> would flipping that expression to
>
> full_exclude_list = EXCLUDE_LIST + tuple(BY_HAND)
>
> also mess up the typing?
>
> If that's the case, I'm fine with keeping them as lists, it was a minor nit anyway
Your suggestion made me look at what the deduced type of
`tuple(BY_HAND)` is, it is `tuple[str, ...]`. When I use that as the
type for BY_HAND instead of `list[str]`, it all works fine.
I sent a v2.
Simon
prev parent reply other threads:[~2025-04-11 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 14:49 [PATCH 1/2] gdb: make typing strict in gdb/copyright.py Simon Marchi
2025-04-09 14:49 ` [PATCH 2/2] gdb: fix bugs in gdb/copyright.py, make it use glob patterns Simon Marchi
2025-04-11 13:52 ` Guinevere Larsen
2025-04-11 14:14 ` Simon Marchi
2025-04-11 14:45 ` Guinevere Larsen
2025-04-11 15:28 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9bfb9f4-f9c0-4331-8e04-21c99e58466e@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox