From: Simon Marchi <simark@simark.ca>
To: Kamil Rytarowski <n54@gmx.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Rewrite nbsd_nat_target::pid_to_exec_file to sysctl(3)
Date: Mon, 16 Mar 2020 15:12:54 -0400 [thread overview]
Message-ID: <a935420b-fefc-9a1c-a5ba-189277f09bba@simark.ca> (raw)
In-Reply-To: <20200316182733.25917-1-n54@gmx.com>
On 2020-03-16 2:27 p.m., Kamil Rytarowski wrote:
> procfs on NetBSD is optional and not recommended.
>
> * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
> <sys/sysctl.h>.
> * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
> ---
> gdb/ChangeLog | 6 ++++++
> gdb/nbsd-nat.c | 22 ++++++++++------------
> 2 files changed, 16 insertions(+), 12 deletions(-)
Sorry, I should have made it clear that it was fine to push with the small nit fixed.
This is ok to push :).
Simon
prev parent reply other threads:[~2020-03-16 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 17:14 [PATCH] " Kamil Rytarowski
2020-03-16 17:35 ` Simon Marchi
2020-03-16 18:27 ` [PATCH v2] " Kamil Rytarowski
2020-03-16 19:12 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a935420b-fefc-9a1c-a5ba-189277f09bba@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox