From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ef1WChpUwmmc2TYAWB0awg (envelope-from ) for ; Tue, 24 Mar 2026 05:06:34 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HOYMdarD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fopRYDsf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XOZveUDL; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3l6+mrP5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 15A3E1E04F; Tue, 24 Mar 2026 05:06:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EC4B31E04F for ; Tue, 24 Mar 2026 05:06:32 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 86BE64BB3BDF for ; Tue, 24 Mar 2026 09:06:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86BE64BB3BDF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HOYMdarD; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=fopRYDsf; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XOZveUDL; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3l6+mrP5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id E44314B9DB56 for ; Tue, 24 Mar 2026 09:05:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E44314B9DB56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E44314B9DB56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774343156; cv=none; b=mArs+OUSrNlM6wEqSKTe3jwIPyNlORLal6NymFZbHUVsmaczn3UQ0ED/oq9+qrsjU3jEsWJd7WTMAGyntlWVkgvU5C6yHkBZRHmFoCDzfQSqjW94N5DydRm2AE5uiaYDd2aoeno+ZugVpmH+mxw8ww1IoK0XdSjnwvcUiC+7XBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774343156; c=relaxed/simple; bh=lorAVzAfq6f2mS4/KNiXIVbyBzeIAQbvmjw+2uvIfq4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=DE/3HSEc9INzjdsltSnfDZ/PgVWcoEUn2GjYRELjBDEe5lUcc7yWfgrL1DrlTI/snZRCt4XT0a741Z5WoS27t5CMMgrhJjlxLC04ExjU5FIojsi7NuM77UoxIwZvSrFe7zXROWyH7LLO3VvarL3ziUoLXFus20zhFFq26+gT8MA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E44314B9DB56 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B07B34D1CA; Tue, 24 Mar 2026 09:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774343154; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m51TQIeZvN6yPOryVHSgT7BghrUAQYvt3TvZJz7Tp1A=; b=HOYMdarDiH3ExubvA/0qpzdvP2Kgsms7TA5zjnIfbL6uuDzatXssgIfuwJ1xDTzIZdso7w FtMoEOBr8KV4GhRCk5AHC1gyO6DcySMiG0MtrVvEANLIrk2l8L0ZNRkets9cn7ZvauF/dM 0PA0IaO3TMxJXxMTFc8WAPpKOGx07W0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774343154; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m51TQIeZvN6yPOryVHSgT7BghrUAQYvt3TvZJz7Tp1A=; b=fopRYDsfoBspQoZaMqlbHcXr+5gPUgWU0+Tnp2yDWQJrsSJfjji2xNu2nee7hPagaKrvhJ pR1/hDzvi0lfVCBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XOZveUDL; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3l6+mrP5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774343152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m51TQIeZvN6yPOryVHSgT7BghrUAQYvt3TvZJz7Tp1A=; b=XOZveUDLXlPU2clFNxOFRmggcR3xEZKw7cMUMw4ULZ8Fv0czc2xt18Fcyx8WSqZ0TH/4ZW Yp8McncseUHn6W3O45efKFW2KC7EP7CEVvUT9pWhcEDccd1mckQEEAjThh1Dol3UAU3IYz ZagTrXEC9nrnfeY8cRppfMtNN4P3lxo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774343152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m51TQIeZvN6yPOryVHSgT7BghrUAQYvt3TvZJz7Tp1A=; b=3l6+mrP50iJ5XrMItLWCbMu2X7HIoQCEDnP+M7hMRe9/+3F6KmoNA3MZaXUK4rMTfvGU3X q6575I7LSKBBe4DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9A3AA43D67; Tue, 24 Mar 2026 09:05:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +1sxJPBTwmk0CgAAD6G6ig (envelope-from ); Tue, 24 Mar 2026 09:05:52 +0000 Message-ID: Date: Tue, 24 Mar 2026 10:05:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdbsupport] Poison ctype.h / cctype functions To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260322160338.3224997-1-tdevries@suse.de> <87jyv28wbg.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87jyv28wbg.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid,suse.de:email]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,sourceware.org:url]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: B07B34D1CA X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/23/26 3:17 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> GDB generally uses c_isprint instead of isprint or std::isprint [1]. > Tom> Poison uses of ctype.h / cctype functions in gdbsupport/poison.h. > > Tom> This excludes isupper, islower and toupper because they're currently used in > Tom> GDB. Add a fixme to find out whether these exceptions are ok, and if so > Tom> document why, otherwise fix them. > > Tom> +#define POISON_CCTYPE(F) \ > Tom> + template \ > Tom> + F \ > Tom> + { \ > Tom> + static_assert (false, "Please use gnulib's c-ctype.h"); \ > Tom> + return 0; \ > Tom> + } > Tom> + > Tom> +/* Poisoning of some functions is disabled: > Tom> + - isupper, because it's used in ada_decode. > > This is just an oversight. > I've submitted a patch for this ( https://sourceware.org/pipermail/gdb-patches/2026-March/226148.html ). Thanks, - Tom > Tom> + - islower and toupper, because they're used in UNCTRL from readline, > Tom> + which is used in tui_redisplay_readline and gdb_fnprint. > > Can't really touch readline but we could write our own UNCTRL variant. > > Tom> +POISON_CCTYPE (int isalnum (T c)); > Tom> +POISON_CCTYPE (int std::isalnum (T c)); > > I suspect redefining standard functions like this is not allowed in C++. > > Tom