From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FxLcHZyb8GjijTcAWB0awg (envelope-from ) for ; Thu, 16 Oct 2025 03:15:40 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=T3gNDYBN; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+njXKgUU; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=T3gNDYBN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+njXKgUU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 62C461E0BA; Thu, 16 Oct 2025 03:15:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1876C1E04C for ; Thu, 16 Oct 2025 03:15:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8E872385843A for ; Thu, 16 Oct 2025 07:15:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E872385843A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=T3gNDYBN; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+njXKgUU; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=T3gNDYBN; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+njXKgUU Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id CF6473858D1E for ; Thu, 16 Oct 2025 07:14:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF6473858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF6473858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760598893; cv=none; b=KWg//yFKhBtzoa/Ot45TMaS9OXUuhNlFt4sQNI1sguPmGetRZsAHZ9qDWXmppm2jGH/mzwyoobOUKmXLSw3vpXwfYbPud0pcOJO8cCbj1Eh7Gk92pht0KXbU0Fv156o9r+LZ4VqynPt2wD3243MDsgPz6JD2fsqpKTDTSY4/GsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760598893; c=relaxed/simple; bh=rvuzEPYnhUrtZaV0OjrE1CrMiHr26lTSWNG3KmqhXsQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=fvoWAfJwLGBKLVvapqay2zuZQe196hHesJZEMok7vO/6FryRkS+o3c/B9qzSk5fwjUATTZdFuR6+LLPDx3eLYfMDo8ntisDRDQ84/ALjeLd3RWyfVaf3ancPbDLfaM9A2GtssmDx/qcGL/kXpzdnjBJbWHprC42IpAatSvu28ow= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF6473858D1E Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CD87821DC1; Thu, 16 Oct 2025 07:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1760598891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YUiOAcJyqEvgDX0m3EWDCiZ0HQIl0Eh+TTeZ5JRkPvE=; b=T3gNDYBNfet1FxrZjay2gTPAg9nk7LCdiBN4DEJnP6uDJespXpoGbZ7R4B0HO1QiK0uRJe lCAAV93ZomaU52ufR6xUK3KFfzJfcRyQYFLnsO81StgcjtcVPcmlkh+Mxi0QHu7Ik/kMA8 7b0zcB7nxX+eWYLZqt15+7tqe3TOT9M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1760598891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YUiOAcJyqEvgDX0m3EWDCiZ0HQIl0Eh+TTeZ5JRkPvE=; b=+njXKgUUD9RPSHsRfKB6Q0MKfijaGaqLk0q2bqRlojtyCFAuyxI98RyvP9j7o7vCbi+ZUw nAKazGeEv1TOJCDA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1760598891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YUiOAcJyqEvgDX0m3EWDCiZ0HQIl0Eh+TTeZ5JRkPvE=; b=T3gNDYBNfet1FxrZjay2gTPAg9nk7LCdiBN4DEJnP6uDJespXpoGbZ7R4B0HO1QiK0uRJe lCAAV93ZomaU52ufR6xUK3KFfzJfcRyQYFLnsO81StgcjtcVPcmlkh+Mxi0QHu7Ik/kMA8 7b0zcB7nxX+eWYLZqt15+7tqe3TOT9M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1760598891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YUiOAcJyqEvgDX0m3EWDCiZ0HQIl0Eh+TTeZ5JRkPvE=; b=+njXKgUUD9RPSHsRfKB6Q0MKfijaGaqLk0q2bqRlojtyCFAuyxI98RyvP9j7o7vCbi+ZUw nAKazGeEv1TOJCDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B52741340C; Thu, 16 Oct 2025 07:14:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wfy+Kmub8Gj0TQAAD6G6ig (envelope-from ); Thu, 16 Oct 2025 07:14:51 +0000 Message-ID: Date: Thu, 16 Oct 2025 09:14:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] [gdb] Create script to convert old tests into Dwarf::assemble calls. To: William Ferreira , gdb-patches@sourceware.org References: <20251012211555.8103-1-wqferr@gmail.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20251012211555.8103-1-wqferr@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_TO(0.00)[gmail.com,sourceware.org]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/12/25 11:15 PM, William Ferreira wrote: > + Regarding DW_FORM_exprloc and DW_FORM_block: > + The form is replaced with SPECIAL_expr. > + The entries in the value are interpreted and decoded using the > + dwarf_operations dictionary, and replaced with their names where > + applicable. > + """ > + s = lbrace > + s += self.name + " " > + s += self._format_value(offset_die_lookup) I tried out the script with a test-case I'm about to commit, and ran into: ... Traceback (most recent call last): File "/data/vries/gdb/binutils-gdb.git/./gdb/contrib/dwarf-to-dwarf-assembler.py", line 680, in main(sys.argv) ~~~~^^^^^^^^^^ File "/data/vries/gdb/binutils-gdb.git/./gdb/contrib/dwarf-to-dwarf-assembler.py", line 676, in main generator.generate() ~~~~~~~~~~~~~~~~~~^^ File "/data/vries/gdb/binutils-gdb.git/./gdb/contrib/dwarf-to-dwarf-assembler.py", line 651, in generate self.generate_die(die, indent_count) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ File "/data/vries/gdb/binutils-gdb.git/./gdb/contrib/dwarf-to-dwarf-assembler.py", line 630, in generate_die die_lines = die.format(self.dwarf_parser.offset_to_die, indent_count) File "/data/vries/gdb/binutils-gdb.git/./gdb/contrib/dwarf-to-dwarf-assembler.py", line 303, in format return "\n".join(self.format_lines(offset_die_lookup, indent_count)) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/data/vries/gdb/binutils-gdb.git/./gdb/contrib/dwarf-to-dwarf-assembler.py", line 405, in format_lines inner_lines = super().format_lines( offset_die_lookup, indent_count + 1 ) File "/data/vries/gdb/binutils-gdb.git/./gdb/contrib/dwarf-to-dwarf-assembler.py", line 271, in format_lines attr_line = attr.format( offset_die_lookup, indent_count=indent_count + 1 ) File "/data/vries/gdb/binutils-gdb.git/./gdb/contrib/dwarf-to-dwarf-assembler.py", line 205, in format s += self.name + " " ~~~~~~~~~~^~~~~ TypeError: unsupported operand type(s) for +: 'int' and 'str' ... The problem is that gcc 15 is using dwarf6 attribute DW_AT_language_name with value 144 (0x90), which is unknown to the script. Using this patch: ... diff --git a/gdb/contrib/dwarf-to-dwarf-assembler.py b/gdb/contrib/dwarf-to-dwarf-assembler.py index 4d545cf4b13..13df3c78345 100755 --- a/gdb/contrib/dwarf-to-dwarf-assembler.py +++ b/gdb/contrib/dwarf-to-dwarf-assembler.py @@ -202,7 +202,11 @@ class DWARFAttribute: applicable. """ s = lbrace - s += self.name + " " + if isinstance(self.name, int): + s += "DW_AT_" + str(self.name) + else: + s += self.name + s += " " s += self._format_value(offset_die_lookup) # Only explicitly state form if it's not a reference. ... I get: ... {DW_AT_language 33 DW_FORM_data1} {DW_AT_144 4 DW_FORM_data1} {DW_AT_145 201703 DW_FORM_data4} {DW_AT_name /data/vries/gdb/src/gdb/testsuite/gdb.cp/pretty-print.cc DW_FORM_line_strp} ... I haven't looked at whether that output makes sense with the dwarf assembler, perhaps there's a better way, but at least this allows the script to finish and makes it reasonably clear what the situation is. Thanks, - Tom