From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26796 invoked by alias); 27 May 2019 17:33:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26787 invoked by uid 89); 27 May 2019 17:33:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1114 X-HELO: mail-wr1-f43.google.com Received: from mail-wr1-f43.google.com (HELO mail-wr1-f43.google.com) (209.85.221.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 May 2019 17:33:14 +0000 Received: by mail-wr1-f43.google.com with SMTP id s17so17556475wru.3 for ; Mon, 27 May 2019 10:33:14 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id l18sm30911570wrh.54.2019.05.27.10.33.11 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 27 May 2019 10:33:11 -0700 (PDT) Subject: Re: [RFAv3 2/6] Improve process exit status macros on MinGW To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20190504161753.15530-1-philippe.waroquiers@skynet.be> <20190504161753.15530-3-philippe.waroquiers@skynet.be> From: Pedro Alves Message-ID: Date: Mon, 27 May 2019 17:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190504161753.15530-3-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg00590.txt.bz2 On 5/4/19 5:17 PM, Philippe Waroquiers wrote: > gdb/ChangeLog > 2019-05-04 Eli Zaretskii > Philippe Waroquiers > > * common/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS, > WTERMSIG): Define better versions for MinGW. > * windows-nat.c (xlate): Uncomment the definition. > (windows_status_to_termsig): New function. windows-nat.c looks like the wrong place to put this. windows-nat.c is only included in the build if building a native debugger. But, you need this functionality on every Windows-hosted build of GDB, even cross debuggers. So I think you're breaking the build on the Windows-hosted, non-native-debugger case. E.g., --host=mingw --target=arm-none-eabi. The right place would be mingw-hdep.c. I admit to being a bit confused about why we want to do this translation for this feature while we don't do it for the exit code of inferiors running under gdb, for example. I mean, exit status with 0xc0000000 set don't cause $_exitsignal to be set instead of $_exitcode. Thanks, Pedro Alves