From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24804 invoked by alias); 9 Sep 2018 13:55:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24794 invoked by uid 89); 9 Sep 2018 13:55:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Sep 2018 13:55:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1536501325; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JHMHSlikBIRHzB9b7FnYErELhE6zI9dBplLLCmXRQ2M=; b=M+9mXOGj1mBapL9CLYEgeue26wRVHYTkQ8MYw2phR0s9/mmWNSA6Sm7KN6Rdgf4L Vax+vrDQj70cz0KHRirVBicfpFOfw9FH01KxGZwud6avhKuETiYgxSpfJv1dwMbK bSC6Qr4QlTj+8cqqaShdSy6bvLJrNtzUfctHR33Rx1Q=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 36.C1.31332.D46259B5; Sun, 9 Sep 2018 15:55:25 +0200 (CEST) Received: from ESESSMB503.ericsson.se (153.88.183.164) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sun, 9 Sep 2018 15:55:19 +0200 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB503.ericsson.se (153.88.183.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Sun, 9 Sep 2018 15:55:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1gL6eErw8MP8ndw/mnkRvLtGEE5t6jlKGnomAwpyrhI=; b=m48OqKp8uS48F/QB2tX0Csl9us6ha2vysV/0iqz27aue37baLbcP9HRw1sZy+QIvXyrVJbds9Z40liIKgGqqevlBUELXTa5y4IMEE3PF+hU0lgPNOMbwr1W7pGejGUl2651A502JB0rG29JILUY4SzfOPZX/PI1L4bgMJMtR8kY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [10.187.208.77] (130.88.240.109) by SN6PR15MB2397.namprd15.prod.outlook.com (2603:10b6:805:24::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1122.17; Sun, 9 Sep 2018 13:55:14 +0000 Subject: Re: [RFA 5/5 v2] Darwin: fix SIGTRAP when debugging To: Xavier Roirand , CC: , , References: <1536499653-10033-1-git-send-email-roirand@adacore.com> From: Simon Marchi Message-ID: Date: Sun, 09 Sep 2018 13:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1536499653-10033-1-git-send-email-roirand@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00233.txt.bz2 On 2018-09-09 02:27 PM, Xavier Roirand wrote: > Debugging a program under Darwin does not work: > > (gdb) start > Temporary breakpoint 1 at 0x100000fb4: file /tmp/helloworld.c, line 1. > Starting program: /private/tmp/helloworld > [New Thread 0x2903 of process 60326] > During startup program terminated with signal SIGTRAP, Trace/breakpoint > trap. > > Field signaled from darwin_thread_info is not initialized thus signal > sent to the debuggee is considered as not sent by GDB whereas it should. > > This patch fixes this problem and also updates (change type, initialize) > single_step value in the same structure at the same time. > > gdb/ChangeLog: > > * darwin-nat.h (struct darwin_thread_info) : Change > type and initialize. > (struct darwin_thread_info) : Change type and > initialize. > > Change-Id: I0fe2a6985df9d0dfcc8a2a258a3ef70cfa19b403 > --- > gdb/darwin-nat.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/darwin-nat.h b/gdb/darwin-nat.h > index 5965df08ab6..4232b5e0365 100644 > --- a/gdb/darwin-nat.h > +++ b/gdb/darwin-nat.h > @@ -126,10 +126,10 @@ struct darwin_thread_info : public private_thread_info > enum darwin_msg_state msg_state; > > /* True if this thread is single-stepped. */ > - unsigned char single_step; > + bool single_step = 0; > > /* True if a signal was manually sent to the thread. */ > - unsigned char signaled; > + bool signaled = 0; > > /* The last exception received. */ > struct darwin_exception_msg event; > As mentioned in the last review, I think all files should be initialized to a sensible value, either to a constant value or by the constructor. This is what I would suggest, on top of your patch (not tested). Would that work for you? >From 45abaf5843f1c1f55a233d00cc0c07ed38f64d89 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Sun, 9 Sep 2018 14:53:17 +0100 Subject: [PATCH] fixup --- gdb/darwin-nat.c | 6 ++---- gdb/darwin-nat.h | 6 +++++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c index d23706d..326e97b 100644 --- a/gdb/darwin-nat.c +++ b/gdb/darwin-nat.c @@ -339,10 +339,8 @@ darwin_check_new_threads (struct inferior *inf) if (new_ix < new_nbr && (old_ix == old_nbr || new_id < old_id)) { /* A thread was created. */ - darwin_thread_info *pti = new darwin_thread_info; - - pti->gdb_port = new_id; - pti->msg_state = DARWIN_RUNNING; + darwin_thread_info *pti + = new darwin_thread_info (new_id, DARWIN_RUNNING); /* Add the new thread. */ add_thread_with_info (ptid_t (inf->pid, 0, new_id), pti); diff --git a/gdb/darwin-nat.h b/gdb/darwin-nat.h index 4232b5e..fee535b 100644 --- a/gdb/darwin-nat.h +++ b/gdb/darwin-nat.h @@ -113,12 +113,16 @@ enum darwin_msg_state struct darwin_thread_info : public private_thread_info { + darwin_thread_info (thread_t gdb_port, darwin_msg_state msg_state) + : gdb_port (gdb_port), msg_state (msg_state) + {} + /* The thread port from a GDB point of view. */ thread_t gdb_port; /* The thread port from the inferior point of view. Not to be used inside gdb except for get_ada_task_ptid. */ - thread_t inf_port; + thread_t inf_port = 0; /* Current message state. If the kernel has sent a message it expects a reply and the inferior -- 2.7.4