From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35062 invoked by alias); 18 Sep 2019 20:30:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35000 invoked by uid 89); 18 Sep 2019 20:30:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*M:edu, H*UA:Macintosh, H*u:Macintosh X-HELO: mpv1-2015.case.edu Received: from mpv2-2015.CWRU.Edu (HELO mpv1-2015.case.edu) (129.22.103.227) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2019 20:30:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1568838626; bh=aXmUiCJDgfi4+zqhaqiOQijLvnUR/GM4OoThNQxoJUU=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=re5hGVoCMI7TRFE9UCfvFT0V5AIrn414ZTKHkWdizAhe2G7b1hbN3teBOGyH2uijZB 9T/NmqlUOB2yYc5DZNSlsp0BYwbS4iAc0KX5QilJm8wkopBKkU6HUtV9rY44dVIurVr WDmTcUMTIHQ+vwFlim+8rKpmLIr5h2cESOYn9bRWsa0Vv1KvVnf941EZMLbjPZ0ltXr QwXraV4ejrrz4T6Fwbo0i7EaG3cP+Y7ftrFxz/39359p8ucqm5BUx7PDEa4HH0qFVT2 5sqQxJa9CltJR4/4T4/E9JOM4BFzAxIxPUmk1hz1IdGGwLPdGIaPgZ7dDy1Pt4ukS+D G2MEavPg== Received: from mpv6-2015.CWRU.Edu (EHLO mpv6-2015.case.edu) ([129.22.103.202]) by mpv2-2015.case.edu (MOS 4.4.8-GA FastPath queued) with ESMTP id BBJ79972; Wed, 18 Sep 2019 16:30:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=case.edu; s=smtp-primary; t=1568838625; bh=3zFClya1fOgcM7yrmthZ4UvuSZ3mHg8rx3wXo3BM0n0=; h=Reply-To:Cc:Subject:To:References:From:Message-ID:Date: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=HcNL1MRYN2FbXxhTzESeKQ4URTifC5966sBg0ATYb+s8RvN20XwMDYWUD8983nnu5+ e8RcmXeQCF4osC+6McxjUfWfUoaRK4IsI9wWqe5Tn2CTBihJZ7bSvl5LuELA7xLdxwn i4rPR7uYDU5A2uHO/u7QgSsOAP5ePAt51yoXp3ANWdTf9LTD5miSJvSsyvY7iSYncx+ Qkq/7u7u2oGl3LuQoxisB1mypDqGTCfByISeZTzu+mW6b1fRRaSoJMI7rrddfbYECgf KsAKDhrONYLEYlMdFHSKFOeefnLf9uJ4tt9GUDBNqKPTGz1fEV6gSjSmKdCkhGrbsoD h8+7VuGg== Received: from caleb.INS.CWRU.Edu (EHLO caleb.ins.cwru.edu) ([129.22.8.211]) by mpv6-2015.case.edu (MOS 4.4.8-GA FastPath queued) with ESMTP id CYH55279 (AUTH cpr); Wed, 18 Sep 2019 16:30:25 -0400 (EDT) Reply-To: chet.ramey@case.edu Cc: chet.ramey@case.edu, Tom de Vries Subject: Re: [Bug-readline] [PATCH] gdb/readline: fix use of an undefined variable To: Andrew Burgess , gdb-patches@sourceware.org, bug-readline@gnu.org References: <20190918201127.2791-1-andrew.burgess@embecosm.com> From: Chet Ramey Openpgp: preference=signencrypt Message-ID: Date: Wed, 18 Sep 2019 20:30:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20190918201127.2791-1-andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Junkmail-PrAS-Raw: score=10/90, refid=2.7.2:2019.9.18.200017:17:10.433, ip=, rules=DKIM_SIGNATURE, __HAS_REPLYTO, __HAS_CC_HDR, __MULTIPLE_RCPTS_CC_X2, __CC_NAME, __CC_NAME_DIFF_FROM_ACC, __SUBJ_REPLY, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __SUBJ_ALPHA_END, __TO_MALFORMED_2, __TO_NAME, __TO_NAME_DIFF_FROM_ACC, __HAS_REFERENCES, __REFERENCES, __HAS_FROM, FROM_EDU_TLD, __HAS_MSGID, __SANE_MSGID, DATE_TZ_NA, __USER_AGENT, __MOZILLA_USER_AGENT, __MIME_VERSION, __IN_REP_TO, __CT, __CT_TEXT_PLAIN, __CTE, __REPLYTO_SAMEAS_FROM_ADDY, __REPLYTO_SAMEAS_FROM_ACC, __FROM_DOMAIN_IN_ANY_CC2, __TO_IN_SUBJECT2, __REPLYTO_SAMEAS_FROM_DOMAIN, __DKIM_ALIGNS_1, __DKIM_ALIGNS_2, __ANY_URI, __URI_WITH_PATH, __URI_NO_WWW, __RUS_OBFU_PHONE, __CP_URI_IN_BODY, __SUBJ_ALPHA_NEGATE, __URI_IN_BODY, __URI_NOT_IMG, __FORWARDED_MSG, __BODY_NO_MAILTO, __NO_HTML_TAG_RAW, BODY_SIZE_700_799, BODYTEXTP_SIZE_3000_LESS, __MIME_TEXT_P1, __MIME_TEXT_ONLY, [TRUNCATED], so=2010-03-03 19:42:08, dmn=2016-08-03-0138 X-SW-Source: 2019-09/txt/msg00349.txt.bz2 On 9/18/19 4:11 PM, Andrew Burgess wrote: > This commit in binutils-gdb: > > commit 830b67068cebe7db0eb0db3fa19244e03859fae0 > Date: Fri Jul 12 09:53:02 2019 +0200 > > [readline] Fix heap-buffer-overflow in update_line > > Which corresponds to this commit in upstream readline: > > commit 31547b4ea4a1a904e1b08e2bc4b4ebd5042aedaa > Date: Mon Aug 5 10:24:27 2019 -0400 > > commit readline-20190805 snapshot > > Introduced a use of an undefined variable, which can be seen using > valgrind: Thanks for the report and fix. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, UTech, CWRU chet@case.edu http://tiswww.cwru.edu/~chet/