From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82512 invoked by alias); 23 Oct 2017 10:25:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82498 invoked by uid 89); 23 Oct 2017 10:25:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1550, Joel, joel X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Oct 2017 10:25:47 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 674942967; Mon, 23 Oct 2017 10:25:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 674942967 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1CB05DA68; Mon, 23 Oct 2017 10:25:45 +0000 (UTC) Subject: Re: [RFA v4] enable/disable sub breakpoint range To: Xavier Roirand , gdb-patches@sourceware.org References: <83lgks1e1h.fsf@gnu.org> <57a9cdc7-a5fc-0852-8ebe-c7c32c78d475@adacore.com> <77911433-028a-ee7c-e617-eb1fd84f65c0@redhat.com> From: Pedro Alves Message-ID: Date: Mon, 23 Oct 2017 10:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00711.txt.bz2 On 10/23/2017 11:07 AM, Xavier Roirand wrote: > Hello, > > Seems that my v3 patch sent in my previous email was not merging fine so > here's a rebased version. Hope it will work better. > Hmm, I still get (against current master / f6af9f3428fa): $ patch --dry-run -i patch.diff -p1 checking file gdb/NEWS checking file gdb/breakpoint.c Hunk #1 FAILED at 93. Hunk #2 FAILED at 14160. Hunk #3 FAILED at 14178. Hunk #4 FAILED at 14222. Hunk #6 FAILED at 14287. Hunk #7 FAILED at 14396. 6 out of 7 hunks FAILED checking file gdb/doc/gdb.texinfo checking file gdb/testsuite/gdb.cp/locbprange.cc checking file gdb/testsuite/gdb.cp/locbprange.exp Not sure why... Does it work for you if you copy paste it from your mail client? There's a leading indentation in all lines in the commit log below which suggests to me that you copy/pasted the patch from the output of "git show"? A better way is to use "git format-patch -1" instead. That makes it possible to use "git am" to import a patch. Please can you try that, and send the result as an attachment. [Please also look into git send-email for the future. It should make things smoother. Joel uses that so I assume it wouldn't be a problem on your server's end.] > ----- > > Allow enabling/disabling breakpoint location range > > In some cases, adding one breakpoint corresponds to multiple > places in a program thus leads GDB to define main breakpoint > number and other breakpoints using location number with syntax: > ... Thanks, Pedro Alves