From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118085 invoked by alias); 10 May 2018 15:38:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118069 invoked by uid 89); 10 May 2018 15:38:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1330 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 May 2018 15:38:12 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w4AFc5rQ010799 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 10 May 2018 11:38:10 -0400 Received: by simark.ca (Postfix, from userid 112) id C7B8D1F215; Thu, 10 May 2018 11:38:05 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 3A1A91E4F4; Thu, 10 May 2018 11:38:04 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 10 May 2018 16:47:00 -0000 From: Simon Marchi To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/gdbserver] x86 LynxOS-178: Adjust floating-point context structure In-Reply-To: <1525964730-8822-2-git-send-email-brobecker@adacore.com> References: <1525964730-8822-1-git-send-email-brobecker@adacore.com> <1525964730-8822-2-git-send-email-brobecker@adacore.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 10 May 2018 15:38:05 +0000 X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00240.txt.bz2 On 2018-05-10 11:05, Joel Brobecker wrote: > The floating point context structure on x86 LynxOS-178 is not > the same as on LynxOS 5.x. As a consequence, trying to print > the return value of a function returning a float, for instance, > yields incorrect results. > > This patch fixes the issue by providing an updated definition > for LynxOS-178 (the reason why we cannot access the actual definition > provided by the system still remains true). > > gdb/gdbserver/ChangeLog: > > * lynx-i386-low.c (LYNXOS_178): New macro. > (usr_fcontext_t) : Provide a definition that > matches > the layout on LynxOS-178. This syntax (with < >) is usually meant to denote fields (as if you were referring to field LYNXOS_178 in structure usr_fcontext_t). To denote an #ifdef context (which is what I understand you want to do), I usually see this syntax: [LYNXOS_178] (usr_fcontext_t): ... For example: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/ChangeLog-2017;h=aaadf142a4641ecd3feb26bc1dfa83dcc19e713c;hb=HEAD#l13806 > (lynx_i386_fill_fpregset, lynx_i386_store_fpregset): Do not > handle floating point registers that are not supported by > LynxOS-178. > > OK to push to master? Otherwise, it looks good to me. Simon