From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-149682-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 58706 invoked by alias); 9 Aug 2018 18:50:32 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 58690 invoked by uid 89); 9 Aug 2018 18:50:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:433
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Aug 2018 18:50:31 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id CFC7B5BCB6;	Thu,  9 Aug 2018 18:50:29 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 512C223155;	Thu,  9 Aug 2018 18:50:29 +0000 (UTC)
Subject: Re: [PATCH 1/7] Change completion_tracker to use char type
To: Tom Tromey <tom@tromey.com>
References: <20180808232016.12777-1-tom@tromey.com> <20180808232016.12777-2-tom@tromey.com> <f4419039-156c-7fb2-0671-491ed0132351@redhat.com> <87d0uridpt.fsf@tromey.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <a89ed047-ef37-9cab-bc9b-5696456e244c@redhat.com>
Date: Thu, 09 Aug 2018 18:50:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <87d0uridpt.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-08/txt/msg00231.txt.bz2

On 08/09/2018 07:42 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> See comment about use of int vs char here:
> Pedro>  https://sourceware.org/ml/gdb-patches/2017-07/msg00228.html
> Pedro> Look for "Why int".
> 
> Thanks.  How about just this patch, that adds a couple of casts at the
> necessary spots?

LGTM.

Thanks,
Pedro Alves