From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123314 invoked by alias); 10 May 2017 03:26:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123303 invoked by uid 89); 10 May 2017 03:26:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 May 2017 03:26:48 +0000 Received: by simark.ca (Postfix, from userid 33) id A00A21E4A4; Tue, 9 May 2017 23:26:49 -0400 (EDT) To: Tim Wiederhake Subject: Re: [PATCH v3 08/12] btrace: Replace struct btrace_thread_info::up. X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 10 May 2017 03:26:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com In-Reply-To: <1494312929-22749-9-git-send-email-tim.wiederhake@intel.com> References: <1494312929-22749-1-git-send-email-tim.wiederhake@intel.com> <1494312929-22749-9-git-send-email-tim.wiederhake@intel.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.5 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00238.txt.bz2 On 2017-05-09 02:55, Tim Wiederhake wrote: > This used to hold a function segment pointer. Change it to hold an > index into > the vector of function segments instead. > > 2017-05-09 Tim Wiederhake > > gdb/ChangeLog: > > * btrace.c (ftrace_find_call_by_number): New function. > (ftrace_update_caller, ftrace_new_call, ftrace_new_tailcall, > ftrace_get_caller, ftrace_find_call, ftrace_new_return, > ftrace_match_backtrace, ftrace_connect_bfun, ftrace_connect_backtrace, > ftrace_bridge_gap, btrace_bridge_gaps): Use btrace_function::up as an > index. > * btrace.h (struct btrace_function): Turn UP into an index. > * python/py-record-btrace.c (btpy_call_up): Use btrace_function::up > as an index. > * record-btrace.c (record_btrace_frame_unwind_stop_reason, > record_btrace_frame_prev_register, record_btrace_frame_sniffer, > record_btrace_tailcall_frame_sniffe): Same. LGTM, just a question below. > @@ -1629,11 +1629,12 @@ record_btrace_frame_prev_register (struct > frame_info *this_frame, > bfun = cache->bfun; > gdb_assert (bfun != NULL); > > - caller = bfun->up; > - if (caller == NULL) > + if (bfun->up == 0) > throw_error (NOT_AVAILABLE_ERROR, > _("No caller in btrace record history")); > > + caller = cache->tp->btrace.functions[bfun->up - 1]; > + Would it be good to export ftrace_find_call_by_number so it can be used at a few places in this file? Thanks, Simon