From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-135486-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 128101 invoked by alias); 30 Nov 2016 21:32:27 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 128084 invoked by uid 89); 30 Nov 2016 21:32:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 21:32:25 +0000
Received: by simark.ca (Postfix, from userid 33)	id 5D69B1E18F; Wed, 30 Nov 2016 16:32:24 -0500 (EST)
To: Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 22/22] Introduce enum_flag type for ui_out flags
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 30 Nov 2016 21:32:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
In-Reply-To: <82c0febd-7237-15c8-b952-8ef978b1cd8e@redhat.com>
References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124153228.25177-22-simon.marchi@polymtl.ca> <82c0febd-7237-15c8-b952-8ef978b1cd8e@redhat.com>
Message-ID: <a883f3fb9aac2d3d47ccd452e1a5974f@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.2
X-IsSubscribed: yes
X-SW-Source: 2016-11/txt/msg01026.txt.bz2

On 2016-11-30 08:34, Pedro Alves wrote:
> On 11/24/2016 03:32 PM, Simon Marchi wrote:
>> This patch changes the ui_out flags to be an enum flag.
> 
> OK.
> 
>> 
>>  /* flags enum */
>> -enum ui_flags
>> +enum ui_out_flag
>>    {
>> -    ui_from_tty = 1,
>>      ui_source_list = 2
>>    };
>> 
>> +DEF_ENUM_FLAGS_TYPE (ui_out_flag, ui_out_flags);
> 
> Please add an "#include common/enum-flags.h", so the file
> includes what it needs instead of relying on indirect includes.

Good catch, I am not very good at remembering that.