From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61102 invoked by alias); 23 Mar 2017 17:39:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60289 invoked by uid 89); 23 Mar 2017 17:39:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Mar 2017 17:39:04 +0000 Received: by simark.ca (Postfix, from userid 33) id C840D1E7F5; Thu, 23 Mar 2017 13:39:03 -0400 (EDT) To: Pedro Alves Subject: Re: [PATCH] Remove some unnecessary inferior_ptid setting/restoring when fetching/storing registers X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Mar 2017 17:39:00 -0000 From: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org In-Reply-To: <8cc3a2c4-391a-c001-56f5-80f366096e3f@redhat.com> References: <20170322172919.26538-1-simon.marchi@ericsson.com> <8cc3a2c4-391a-c001-56f5-80f366096e3f@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00424.txt.bz2 On 2017-03-23 12:19, Pedro Alves wrote: > On 03/22/2017 05:29 PM, Simon Marchi wrote: >> Now that the to_fetch_registers, to_store_registers and >> to_prepare_to_store target methods don't rely on the value of >> inferior_ptid anymore, we can remove a bunch of now unnecessary >> setting >> and restoring of inferior_ptid. >> >> The asserts added recently in target_fetch_registers and >> target_store_registers, which validate that inferior_ptid matches the >> regcache's ptid, must go away. It's the whole point of this effort, >> to >> not require inferior_ptid to have a particular value when calling >> these >> functions. >> >> One thing that I noticed is how sol-thread.c's ps_lgetregs and friends >> use the current value of inferior_ptid instead of what's passed as >> argument (ph->ptid), unlike proc-service.c's versions of the same >> functions. Is it expected? I left it like this in the current patch, >> but unless there's a good reason for it to be that way, I guess we >> should make it use the parameter. > > Probably no good reason. > > >> >> gdb/ChangeLog: >> >> * fbsd-tdep.c (fbsd_corefile_thread): Don't set/restore >> inferior_ptid. >> * proc-service.c (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, >> ps_lsetfpregs): Likewise. >> * regcache.c (regcache_raw_update, regcache_raw_write): Likewise. >> * sol-thread.c (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, >> ps_lsetfpregs): Likewise. >> * target.c (target_fetch_registers, target_store_registers): >> Remove asserts. > > LGTM. Thanks, pushed.