From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100258 invoked by alias); 11 Jul 2019 01:21:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100250 invoked by uid 89); 11 Jul 2019 01:21:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=our X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 01:21:27 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 71EEE1E472; Wed, 10 Jul 2019 21:21:25 -0400 (EDT) Subject: Re: [PATCH] breakpoint: Make is_*point functions return bool To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20190710165020.17677-1-simon.marchi@efficios.com> <877e8pd2of.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Thu, 11 Jul 2019 01:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <877e8pd2of.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00290.txt.bz2 On 2019-07-10 5:01 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> This includes changing the FILTER parameters of two functions > Simon> accordingly. I also tried to normalize the function comments to our > Simon> current standards. > > Thanks, this looks good to me. > > Tom > Thanks, pushed. Simon