From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39465 invoked by alias); 20 Sep 2017 15:19:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38406 invoked by uid 89); 20 Sep 2017 15:19:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=welcome!, Hx-languages-length:1105, Tel, tel X-HELO: mga06.intel.com Received: from mga06.intel.com (HELO mga06.intel.com) (134.134.136.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Sep 2017 15:19:56 +0000 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 20 Sep 2017 08:19:51 -0700 X-ExtLoop1: 1 Received: from labpc1530.iul.intel.com ([172.28.48.195]) by fmsmga006.fm.intel.com with ESMTP; 20 Sep 2017 08:19:50 -0700 Subject: Re: [PATCH] icc: allow code path for newer versions of icc. To: Simon Marchi References: <1504687613-14649-1-git-send-email-walfred.tedeschi@intel.com> <59e18301-7b12-2e92-6277-0aef4164243e@redhat.com> <914ad9ed-940e-81e1-e7de-6c018d29aec7@intel.com> <4bc75ec493ddeb1500c51812a51e8182@polymtl.ca> Cc: Pedro Alves , qiyaoltc@gmail.com, gdb-patches@sourceware.org From: "Tedeschi, Walfred" Message-ID: Date: Wed, 20 Sep 2017 15:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <4bc75ec493ddeb1500c51812a51e8182@polymtl.ca> Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00493.txt.bz2 On 09/18/2017 09:13 PM, Simon Marchi wrote: > On 2017-09-18 17:31, Tedeschi, Walfred wrote: >> I am considering sending then two patches: >> 1. Add things in utils.c >> 2. move all producers to a new producers.h/c file. >> >> Would this be ok? > > (I am just speaking for myself) > > I usually prefer the opposite, cleanup first then add new features=20 > (because sometimes the cleanup is promised and never comes :)), but=20 > really I'm fine with both. The fact that you are ready to do some=20 > cleanup is appreciated. > > Simon Hello Simon and Pedro, I have prepared a cleaning patch first and another one with the icc=20 version check. The changes are in: users/wtedesch/icc_version Comments are welcome! Thanks and regards, /Fred Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928