From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157055-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 35300 invoked by alias); 24 Jun 2019 14:13:46 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 35292 invoked by uid 89); 24 Jun 2019 14:13:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=
X-HELO: mail-wr1-f53.google.com
Received: from mail-wr1-f53.google.com (HELO mail-wr1-f53.google.com) (209.85.221.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Jun 2019 14:13:44 +0000
Received: by mail-wr1-f53.google.com with SMTP id c2so14091400wrm.8        for <gdb-patches@sourceware.org>; Mon, 24 Jun 2019 07:13:44 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b])        by smtp.gmail.com with ESMTPSA id y184sm9094116wmg.14.2019.06.24.07.13.41        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Mon, 24 Jun 2019 07:13:42 -0700 (PDT)
Subject: Re: [PATCH 40/66] Remove tui_scroll_direction enum
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20190623224329.16060-1-tom@tromey.com> <20190623224329.16060-41-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <a81c7eca-846a-f62e-cb12-d73f66b2b94d@redhat.com>
Date: Mon, 24 Jun 2019 14:13:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190623224329.16060-41-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-06/txt/msg00529.txt.bz2

On 6/23/19 11:43 PM, Tom Tromey wrote:
> -  do_scroll_vertical (BACKWARD_SCROLL, num_to_scroll);
> +  do_scroll_vertical (- num_to_scroll);

No space after - (unary minus):

 https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Whitespaces

>  
> -  do_scroll_horizontal (RIGHT_SCROLL, num_to_scroll);
> +  do_scroll_horizontal (- num_to_scroll);
>  }

Ditto.

Thanks,
Pedro Alves