From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-156123-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 64878 invoked by alias); 16 May 2019 11:27:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 64870 invoked by uid 89); 16 May 2019 11:27:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:may, H*r:forged, H*r:238, HX-Languages-Length:942
X-HELO: relay.fit.cvut.cz
Received: from relay.fit.cvut.cz (HELO relay.fit.cvut.cz) (147.32.232.237) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 May 2019 11:27:55 +0000
Received: from imap.fit.cvut.cz (imap.fit.cvut.cz [IPv6:2001:718:2:2901:0:0:0:238])	by relay.fit.cvut.cz (8.15.2/8.15.2) with ESMTPS id x4GBRjws052903	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Thu, 16 May 2019 13:27:46 +0200 (CEST)	(envelope-from jan.vrany@fit.cvut.cz)
Received: from sao (02791bac.bb.sky.com [2.121.27.172] (may be forged))         (authenticated bits=0 as user vranyj1)         by imap.fit.cvut.cz (8.15.2/8.15.2) with ESMTPSA id x4GBRfCV010984         (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT);	Thu, 16 May 2019 13:27:41 +0200 (CEST)	(envelope-from jan.vrany@fit.cvut.cz)
Message-ID: <a7daf95d71eaa351bf1196dc43c16d4c8a711ade.camel@fit.cvut.cz>
Subject: Re: [PATCH v4 2/2] MI: Add new command -complete
From: Jan Vrany <jan.vrany@fit.cvut.cz>
To: Pedro Alves <palves@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
Date: Thu, 16 May 2019 11:27:00 -0000
In-Reply-To: <0b9e1f3559ebc9ab24b61d8ed591f448730a5349.camel@fit.cvut.cz>
References: <20190128124101.26243-1-jan.vrany@fit.cvut.cz>	 <20190418115847.19854-3-jan.vrany@fit.cvut.cz>	 <7e80637c-567b-faa5-75fe-e6f04ac9abbd@redhat.com>	 <0b9e1f3559ebc9ab24b61d8ed591f448730a5349.camel@fit.cvut.cz>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5-1
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-05/txt/msg00355.txt.bz2

Polite ping. 

The v5 - hopefully good - is here: 

https://sourceware.org/ml/gdb-patches/2019-04/msg00323.html

Thanks! Jan

On Thu, 2019-04-18 at 15:54 +0100, Jan Vrany wrote:
> On Thu, 2019-04-18 at 15:14 +0100, Pedro Alves wrote:
> > This version is OK, with the tiny issue below addressed.
> > 
> > Can you push this yourself, or do you need someone to do it for you?
> 
> No, I can't. I'll send a v5 with two more fixes shortly - if all is OK, 
> can you push it, please? 
> 
> Thanks! Jan
> 
> > > +/* Implement the "-complete" command.  */
> > > +
> > > +void
> > > +mi_cmd_complete (const char *command, char **argv, int argc)
> > > +{
> > > +  if (argc != 1)
> > > +    error (_("Usage: -complete COMMAND"));
> > > +
> > > +  if (max_completions == 0)
> > > +    error (_("max-completions is zero, completion is disabled.\n"));
> > 
> > errors should not end in \n.
> > 
> > Thanks,
> > Pedro Alves