From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157092-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29989 invoked by alias); 24 Jun 2019 22:21:29 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 29981 invoked by uid 89); 24 Jun 2019 22:21:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*RU:209.85.128.68, HX-Spam-Relays-External:209.85.128.68
X-HELO: mail-wm1-f68.google.com
Received: from mail-wm1-f68.google.com (HELO mail-wm1-f68.google.com) (209.85.128.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Jun 2019 22:21:28 +0000
Received: by mail-wm1-f68.google.com with SMTP id g135so813893wme.4        for <gdb-patches@sourceware.org>; Mon, 24 Jun 2019 15:21:27 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id o185sm592786wmo.45.2019.06.24.15.21.25        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Mon, 24 Jun 2019 15:21:25 -0700 (PDT)
Subject: Re: [PATCH 03/66] Create subclasses for different window types
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20190623224329.16060-1-tom@tromey.com> <20190623224329.16060-4-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <a7c9af77-6210-4f03-6739-8293cb26e402@redhat.com>
Date: Mon, 24 Jun 2019 22:21:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190623224329.16060-4-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-06/txt/msg00566.txt.bz2

On 6/23/19 11:42 PM, Tom Tromey wrote:
> +protected:
>  
> +  tui_win_info (enum tui_win_type type);

I forgot to mention in the earlier pass that I thought that
these ctors should be explicit?

Fine with me to leave it as is, and then fix it all up
in a follow up patch, if that's easier.

Thanks,
Pedro Alves