From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CCgXJ0ZcTWOCxg0AWB0awg (envelope-from ) for ; Mon, 17 Oct 2022 09:44:38 -0400 Received: by simark.ca (Postfix, from userid 112) id 9CBCF1E112; Mon, 17 Oct 2022 09:44:38 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=FNeKh6PK; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0F6C11E0D3 for ; Mon, 17 Oct 2022 09:44:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 864153858D3C for ; Mon, 17 Oct 2022 13:44:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 864153858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666014277; bh=S0CwYbFHdOyW+DJGRfMEjgIrEaNzlhSKo/elznBpLFs=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FNeKh6PK8YuGnivm34nEzUJXgobnmWt8OOOnOh3Ldk3Hz6zpPn7Ww4/y5cRBUS8TK bOXgUS9+DvYL+gJ3f9nZPH3hnMU8KviSC2/AC9tAm5cvY2Oe6nzOc/A0+lx4p3xxbB UJeAx3LVZvmMwJ4Wy0WC+lzgzsYZTikq65IqlWIk= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8C0FE3858D28 for ; Mon, 17 Oct 2022 13:43:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8C0FE3858D28 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 29HDhM8f023110 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 17 Oct 2022 09:43:26 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 29HDhM8f023110 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EF9C11E0D3; Mon, 17 Oct 2022 09:43:21 -0400 (EDT) Message-ID: Date: Mon, 17 Oct 2022 09:43:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v6 1/8] GDB/Guile: Don't assert that an integer value is boolean Content-Language: en-US To: "Maciej W. Rozycki" , gdb-patches@sourceware.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 17 Oct 2022 13:43:22 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Simon Sobisch , Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > gdb-guile-scm-param-is-integer.diff > Index: src/gdb/guile/scm-param.c > =================================================================== > --- src.orig/gdb/guile/scm-param.c > +++ src/gdb/guile/scm-param.c > @@ -742,7 +742,7 @@ pascm_set_param_value_x (param_smob *p_s > if (var.type () == var_uinteger > || var.type () == var_zuinteger_unlimited) > { > - SCM_ASSERT_TYPE (gdbscm_is_bool (value) > + SCM_ASSERT_TYPE (scm_is_integer (value) Was this just a brainfart when the code was initially written? > @@ -206,3 +380,5 @@ with_test_prefix "previously-ambiguous" > gdb_test "help set print s" "This command is not documented." "set help" > gdb_test "help set print" "set print s -- This command is not documented.*" "general help" > } > + > +rename scm_param_test_maybe_no_output "" Just wondering, what is the intention here, to avoid polluting the global namespace? If so, I appreciate the intention, but given we don't do that in thousands of other tests, I'm not sure if it's really useful. Anyhow, this patch LGTM: Approved-By: Simon Marchi Simon