From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98230 invoked by alias); 9 Sep 2017 17:05:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98219 invoked by uid 89); 9 Sep 2017 17:05:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=transfer X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Sep 2017 17:05:48 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v89H5fXd019242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 9 Sep 2017 13:05:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 966181EAB3; Sat, 9 Sep 2017 13:05:41 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id E02A01EA18; Sat, 9 Sep 2017 13:05:39 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 09 Sep 2017 17:05:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/3] Small event ownership clean up in Python layer In-Reply-To: <20170909003353.25883-3-tom@tromey.com> References: <20170909003353.25883-1-tom@tromey.com> <20170909003353.25883-3-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 9 Sep 2017 17:05:41 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00242.txt.bz2 On 2017-09-09 02:33, Tom Tromey wrote: > It seems cleaner to me for functions like create_thread_event_object, > which pass object ownership to their callers, to directly return a > gdb_ref<>. This way the ownership transfer is part of the API. This > patch makes this change. LGTM. Simon