From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WqXDOLSNnWoOcTEAWB0awg (envelope-from ) for ; Sun, 06 Sep 2026 11:58:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=N4yOG3nJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=24ZeL7i3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Doq0yI7Q; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yCumu7gu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D15421E033; Sun, 06 Sep 2026 11:58:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D33591E033 for ; Sun, 06 Sep 2026 11:58:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C89C24BB8F68 for ; Sun, 6 Sep 2026 15:58:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C89C24BB8F68 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=N4yOG3nJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=24ZeL7i3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Doq0yI7Q; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yCumu7gu Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 353E74BB58CD for ; Sun, 6 Sep 2026 15:58:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 353E74BB58CD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 353E74BB58CD Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788710297; cv=none; b=h15Dv87sTLK76aG0wx0tw6XI07d+LyBXe84AbWUzmCpRWkGy+SzX37q+CPiuvLaUYQFe9w0oysUXo8Qn0N8+Ub+Y/SoK+mWSLMWYIbrfYZDylSRj5ffeBTbuSbYnjBgjch1Pww/TgKKmxgbtKteff1lqnqvSYfz7geCQrylnRRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788710297; c=relaxed/simple; bh=S6Z3eNyfkNFteoPOdgD71xi/tDwx3EUbyn9wA1LuXF8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=r8izOChfx8jGcr+KgKT59sYYFLrl2iXuedSWPUbwRvOj3BTjGgVkT4LmNjdfnyZzQWbbdd1FJ4qWKXkZXXbNUciWGDcskX7ZVJy26E119UgmyO4XWOeEcG5fsUpQpjqfPvk15ODBsfH7eevJMfQaMTrTONHuZHpZbghqCoYNMQ0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=N4yOG3nJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=24ZeL7i3; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Doq0yI7Q; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=yCumu7gu DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 353E74BB58CD Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4E4E21F387; Sun, 6 Sep 2026 15:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788710291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t3ag5i/VAoYs428+T5Bu75W5vDIkO9XjT5Jq8NGiiXM=; b=N4yOG3nJVHcazRamonvh8In5URsFvHMmuzE3sZvoiEm8Rcs54YRYbymT/XRldVoihAHL5U P/oan2tSB1fHWpHXav1j8/TIAF5CxZ6NA1tTjfApPUerGf1JC4ykhRnPjt/+bzNLeJD0oK hCUzM0cBP2+jQBaZ9VIxiV5Mybux81Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788710291; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t3ag5i/VAoYs428+T5Bu75W5vDIkO9XjT5Jq8NGiiXM=; b=24ZeL7i3DupcfgDOMAKACXtA0IfG0XgD66aF8t0Mh/MTH+JlpAJL2wMGpMcqOcqDtRGSHo k5cXY9AYCwq3e0Cg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788710287; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t3ag5i/VAoYs428+T5Bu75W5vDIkO9XjT5Jq8NGiiXM=; b=Doq0yI7QSOdWcAz024EV3zQ/NnTi9wzIGUd6VOoxfIx7I7UGL0eUUGXdRPa2R1Iak7/JA1 6kqJqUa1Vf5wh4SYL4ZqleBpX2k8TU4wLpk65RIQUBQdORrlHzCzQaL75QG0rNqayxGW7H e+SN/4Z8RIDzpenGuNG/YFl1qTLIAmQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788710287; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t3ag5i/VAoYs428+T5Bu75W5vDIkO9XjT5Jq8NGiiXM=; b=yCumu7guoLYLaj0VbAC4xxT29Cp83con7KUYEHrOtvbeUuDT1aYMe6oDW9HqQIptk5S2Mm YBSRRcBnrWKOhfDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2256113432; Sun, 6 Sep 2026 15:58:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id h++zA4+NnWp+PQAAD6G6ig (envelope-from ); Sun, 06 Sep 2026 15:58:07 +0000 Message-ID: Date: Sun, 6 Sep 2026 17:58:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb.gdb/python-helper.exp: Increase timeout values To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20260906040140.158197-1-thiago.bauermann@linaro.org> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260906040140.158197-1-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.993]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/6/26 6:01 AM, Thiago Jung Bauermann wrote: > In the three Linux machines I tested (my x86_64 laptop and two aarch64 > servers), gdb.gdb/python-helper.exp has this timeout failure: > > FAIL: gdb.gdb/python-helper.exp: pretty print type instance flags (timeout) > > And the slower aarch64 server also has this one: > > FAIL: gdb.gdb/python-helper.exp: start inner gdb (timeout) > > Fix these failures by using timeout factors. For the latter, a 2x factor > is enough. For the former, I needed 8x. It appears that the "pretty print > type instance flags" test is quite demanding. I tried to see if I could reproduce this. I ended up writing a patch ( https://sourceware.org/pipermail/gdb-patches/2026-September/230135.html ) for some timeout but I have no idea whether it's the same root cause or not. You may want to test it. Assuming it's not, LGTM. Approved-By: Tom de Vries > --- > > I actually noticed these failures because I compared GDB 17.2 test > results with GDB 18 ones. OK to also push to the branch? > This makes me wonder if we're dealing with a performance regression here, but yeah, I suppose it's ok. Thanks, - Tom > gdb/testsuite/gdb.gdb/python-helper.exp | 40 ++++++++++++++----------- > 1 file changed, 22 insertions(+), 18 deletions(-) > > diff --git a/gdb/testsuite/gdb.gdb/python-helper.exp b/gdb/testsuite/gdb.gdb/python-helper.exp > index d84e48166995..bcd94b2e6ae5 100644 > --- a/gdb/testsuite/gdb.gdb/python-helper.exp > +++ b/gdb/testsuite/gdb.gdb/python-helper.exp > @@ -91,19 +91,21 @@ proc test_python_helper {} { > # little clearer when trying to unpick which GDB is active. > gdb_test_no_output -prompt $outer_prompt_re "set prompt (outer-gdb) " "set outer gdb prompt" > > - # Send a command to the outer GDB to continue the inner GDB. The > - # stop is being detected from the inner GDB, hence the use of -i > - # here. > - gdb_test_multiple "continue" "start inner gdb" { > - -re "received signal SIGSEGV.* in GC_.*$outer_prompt_re" { > - # Some versions of the GC used by Guile cause a SEGV > - # during stack probing. Ignore this and carry on. > - send_gdb "continue\n" > - exp_continue > - } > - -i "$inferior_spawn_id" > - -re "\r\n$gdb_prompt $" { > - pass $gdb_test_name > + with_timeout_factor 2 { > + # Send a command to the outer GDB to continue the inner GDB. The > + # stop is being detected from the inner GDB, hence the use of -i > + # here. > + gdb_test_multiple "continue" "start inner gdb" { > + -re "received signal SIGSEGV.* in GC_.*$outer_prompt_re" { > + # Some versions of the GC used by Guile cause a SEGV > + # during stack probing. Ignore this and carry on. > + send_gdb "continue\n" > + exp_continue > + } > + -i "$inferior_spawn_id" > + -re "\r\n$gdb_prompt $" { > + pass $gdb_test_name > + } > } > } > > @@ -172,11 +174,13 @@ proc test_python_helper {} { > " int_stuff = \{ bit_size = $decimal, bit_offset = $decimal \}\}"] > gdb_test -prompt $outer_prompt_re "print *val->m_type->main_type" $answer "pretty print type->main_type" > > - # Test printing instance flags using an artificial type. > - set answer [string_to_regexp {instance_flags = [VOLATILE|DATA_SPACE|ADDRESS_CLASS(3)]}] > - gdb_test -prompt $outer_prompt_re \ > - "print *make_type_with_harvard_address_space (make_cv_type (0, 1, make_type_with_address_class (val->m_type, 3)), 2)" \ > - "${answer}.*" "pretty print type instance flags" > + with_timeout_factor 8 { > + # Test printing instance flags using an artificial type. > + set answer [string_to_regexp {instance_flags = [VOLATILE|DATA_SPACE|ADDRESS_CLASS(3)]}] > + gdb_test -prompt $outer_prompt_re \ > + "print *make_type_with_harvard_address_space (make_cv_type (0, 1, make_type_with_address_class (val->m_type, 3)), 2)" \ > + "${answer}.*" "pretty print type instance flags" > + } > > # Send the continue to the outer GDB, which resumes the inner GDB, > # we then detect the prompt from the inner GDB, hence the use of