Re: [PATCH 2/2 ] PowerPC: fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp

Simon Marchi via Gdb-patches
2023-03-25T12:40:27Z

On 3/24/23 18:16, Carl Love wrote:
> On Fri, 2023-03-24 at 13:23 -0400, Simon Marchi wrote:
>>
>
> <snip>
>
>> I don't know if that particular failure has been reported yet, but I
>> see
>> these failures when running with native-gdbserver or
>> native-extended-gdbserver:
>>
>> $ make check TESTS="gdb.reverse/finish-reverse-next.exp"
>> RUNTESTFLAGS="--target_board=native-gdbserver"
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse-finish function1
>> LEP call from LEP
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 LEP entry
>> point function call from LEP
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2, at b =
>> 5, call from LEP
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse-finish function1
>> LEP call from function body
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 LEP from
>> function body
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 5,
>> from function body
>> FAIL: gdb.reverse/finish-reverse-next.exp: function1 GEP call call
>> from GEP
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 GEP entry
>> point function call from GEP
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b =
>> 50, call from GEP
>> FAIL: gdb.reverse/finish-reverse-next.exp: function1 GEP call call
>> from GEP again
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 GEP entry
>> point function call from GEP again
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b =
>> 50, call from GEP again
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse-finish function1
>> GEP call, from function body
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 GEP call
>> from function body
>> FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 50
>> from function body
>
> Yes, there was a regression failure. The following was committed to
> fix the reported regression issues.
>
> https://sourceware.org/pipermail/gdb-patches/2023-March/198139.html

I also saw these regressions, but they are fixed (by that commit). This
seems like a different thing.

> Are you testing with this fix?

Yes, and I just tried with today's master, same thing.

> I don't normally run the tests with --target_board=native-gdbserver but
> I did try that and it seemed to work for me. Note I had to also
> specify GDBFLAGS to get the test to run. Specifically, I used the
> command:
>
> make check TESTS="gdb.reverse/finish-reverse-next.exp" RUNTESTFLAGS="GDBFLAGS=' ' --target_board=native-gdbserver "

That's odd, I never had to do that thing with GDBFLAGS. What happens
when you don't specify it?

For reference, here's an example failure:

147 reverse-next^M
148 81 b = 5;^M
149 (gdb) FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 1 LEP from function body
150 reverse-next^M
151 80 a = 1;^M
152 (gdb) FAIL: gdb.reverse/finish-reverse-next.exp: reverse next 2 at b = 5, from function body

Simon