From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iNc4HsuicGXVKRkAWB0awg (envelope-from ) for ; Wed, 06 Dec 2023 11:35:23 -0500 Received: by simark.ca (Postfix, from userid 112) id 73C1F1E0D2; Wed, 6 Dec 2023 11:35:23 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6684C1E00F for ; Wed, 6 Dec 2023 11:35:21 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1EF9638582BD for ; Wed, 6 Dec 2023 16:35:21 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id BB59D3858C62 for ; Wed, 6 Dec 2023 16:35:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB59D3858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB59D3858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701880507; cv=none; b=fxjn0WmRn+q/mAlq/Or7+x/9nOTUZ91k61ELChDeWk8BSoX7Sd7hziDynnCrgjv5Uf+ffqTCIggAOjHGLJ12eaA/Qxx3pjObmQH9A3G2zp1DOoHIH6RayYgJQ7ktZjsUfuGqFPd9XnMRnLi1UGb7plW2qU/geWXNmpt8qq3SpIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701880507; c=relaxed/simple; bh=gzRxa2eaiUAmCUxXGxqovkbjvxnkZyJLHzFQLuk+OZg=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=ee4XJ2aH0epAHgkz6VIVwTzSUhxzx5kJpSYdUeH/eqRAV9XasCAtLWXOslrvMdzORpT84OWnvjsSeEgjPC9JdrR5Qm77a//lZr1o9PmbozC3BAd8LpCoHBBmph/3ZY1qBkY+KTlORiXQUrTF0mX3EgP6l9j3BsX8vIgfsGCh+2Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C2BB91FD2D; Wed, 6 Dec 2023 16:35:04 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 93AF0136CD; Wed, 6 Dec 2023 16:35:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bPyXIriicGWmZQAAD6G6ig (envelope-from ); Wed, 06 Dec 2023 16:35:04 +0000 Message-ID: Date: Wed, 6 Dec 2023 17:35:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: make gdb_get_worker_threads reads default number of threads Content-Language: en-US To: Andrew Burgess , Keith Seitz , Guinevere Larsen , gdb-patches@sourceware.org References: <20231205152609.741237-1-blarsen@redhat.com> <481d8b16-8e3f-45aa-9c01-ed398bb63dd5@redhat.com> <878r67gv2j.fsf@redhat.com> From: Tom de Vries In-Reply-To: <878r67gv2j.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C2BB91FD2D X-Spam-Level: X-Spamd-Result: default: False [-3.00 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; R_SPF_SOFTFAIL(0.00)[~all:c]; BAYES_HAM(-3.00)[100.00%]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[suse.de : No valid SPF, No valid DKIM,none] X-Spam-Score: -3.00 Authentication-Results: smtp-out2.suse.de; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.de (policy=none); spf=softfail (smtp-out2.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tdevries@suse.de) smtp.mailfrom=tdevries@suse.de X-Rspamd-Server: rspamd1 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 12/6/23 17:22, Andrew Burgess wrote: > Keith Seitz writes: > >> Hi, >> >> On 12/5/23 07:26, Guinevere Larsen wrote: >> >>> One such example is the current buildbot instance (at least the clang >>> version). This commit adds a new clause to the gdb_get_worker_threads >>> that detects the default worker thread message. >>> --- >>> gdb/testsuite/lib/gdb.exp | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >>> index d0990dcfe0e..148476cf42d 100644 >>> --- a/gdb/testsuite/lib/gdb.exp >>> +++ b/gdb/testsuite/lib/gdb.exp >>> @@ -10034,6 +10034,9 @@ proc gdb_get_worker_threads { {testname ""} } { >>> -wrap -re "^The number of worker threads GDB can use is unlimited \\(currently ($::decimal)\\)\\." { >>> set worker_threads $expect_out(1,string) >>> } >>> + -wrap -re "^The number of worker threads GDB can use is the default \\(currently ($::decimal)\\)\\." { >>> + set worker_threads $expect_out(1,string) >>> + } >>> -wrap -re "^The number of worker threads GDB can use is ($::decimal)\\." { >>> set worker_threads $expect_out(1,string) >>> } >> >> This is new: >> >> 33ae45434d0ab1f7de365b9140ad4e4ffc34b8a2 >> Date: Mon Dec 4 14:23:17 2023 +0000 >> >> gdb: Enable early init of thread pool size >> >> That commit changes the "is unlimited" text from >> maintenance_show_worker_threads to "is the default": >> >> gdb_printf (file, _("The number of worker threads GDB " >> - "can use is unlimited (currently %zu).\n"), >> + "can use is the default (currently %zu).\n"), >> gdb::thread_pool::g_thread_pool->thread_count ()); >> >> So this patch can be further simplified. Otherwise LGTM. > > Indeed. This was my mistake for not retesting after the final rebase. > As Keith said s/unlimited/the default/ instead of adding a whole new > regexp, and this is good to go. > > Approved-By: Andrew Burgess FTR, AFAICT this already has been fixed by commit 66e00622a89 ("gdb/testsuite: Update worker thread show assertion"). Thanks, - Tom