From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /LWvNoy0jV/9SwAAWB0awg (envelope-from ) for ; Mon, 19 Oct 2020 11:45:16 -0400 Received: by simark.ca (Postfix, from userid 112) id C9FA01EDF4; Mon, 19 Oct 2020 11:45:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3172B1E4B5 for ; Mon, 19 Oct 2020 11:45:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CCB1C3857C4F; Mon, 19 Oct 2020 15:45:15 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 5D8DB3857C4F for ; Mon, 19 Oct 2020 15:45:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5D8DB3857C4F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 839BD1E4B5; Mon, 19 Oct 2020 11:45:13 -0400 (EDT) Subject: Re: [PING][PING] Added x86_64 stub for debugging embedded systems running on Intel x86_64 processor architecture. To: "Battig, Caleb" , "gdb-patches@sourceware.org" References: <84cb0009-cbd5-975a-cdaf-ac8cd77686aa@simark.ca> From: Simon Marchi Message-ID: Date: Mon, 19 Oct 2020 11:45:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: tl Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Lovett, Stuart" , "Peikes, Wendy" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-10-19 10:43 a.m., Battig, Caleb wrote: > Simon, > > Thanks for getting back to me! I resent the original message below. Please let me know if it still hasn't gone through. > > The use case of the new x86_64 stub is the same as the old x86 stub, except it works with newer 64-bit processors. See - > https://sourceware.org/gdb/onlinedocs/gdb/Remote-Stub.html (Notice that there is no 64-bit stub in the list of stubs provided by GDB.) > https://sourceware.org/gdb/onlinedocs/gdb/Debug-Session.html#Debug-Session > > Thanks and let me know if you have any further questions! Thanks. I've reached to other maintainers to know what our policy is today with these files, regarding licensing. The existing stubs have been contributed a loooong time ago, so it might have changed. I'll let you know. In the mean time, could you do your best to make the code adhere to our formatting conventions? What I spotted mostly: - Whitespaces: Indentation of 2 columns. Whole groups of 8 columns use a tab, and then spaces are used for the remainder. - "static" and the return type on their own line: static void foo (int bar) { ... } - Space before parenthesis in prototypes and calls. Basically, just look at other files, such as gdb/infrun.c, that will give you a good idea. Thanks, Simon