Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
	vladimir.mezentsev@oracle.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb passes and returns incorrect values when dealing with small array on Sparc
Date: Fri, 19 May 2017 09:57:00 -0000	[thread overview]
Message-ID: <a6e9de3d-57cf-2dd9-08d9-0c87779c739d@redhat.com> (raw)
In-Reply-To: <87shk1mb99.fsf@oracle.com>

On 05/19/2017 10:44 AM, Jose E. Marchesi wrote:
> 
>     From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>     
>     gdb has a special type (TYPE_CODE_ARRAY) to support the gcc extension
>     (https://gcc.gnu.org/onlinedocs/gcc/Vector-Extensions.html).
>     TYPE_CODE_ARRAY is handled incorrectly for both (32- and 64-bit) modes on Sparc machines.
>     
>     Tested on sparc64-linux-gnu and sparc-solaris (32- and 64-bit mode).
>     No regressions.
>     
>     gdb/ChangeLog:
>     2017-05-12  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
>     
>     	* sparc-tdep.c (sparc_structure_return_p)
>     	(sparc_arg_on_registers_p): New functions.
>     	(sparc32_store_arguments): Use them.
>     	* sparc64-tdep.c (sparc64_16_byte_align_p)
>     	(sparc64_store_floating_fields, sparc64_extract_floating_fields):
>     	Handle TYPE_CODE_ARRAY.
> 
> 
> LGTM.  Ok for master?
> 

OK with the commit log tweak mentioned at:

 https://sourceware.org/ml/gdb-patches/2017-04/msg00509.html

Thanks,
Pedro Alves


  reply	other threads:[~2017-05-19  9:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16 16:16 vladimir.mezentsev
2017-05-19  9:44 ` Jose E. Marchesi
2017-05-19  9:57   ` Pedro Alves [this message]
2017-05-19 10:19     ` Jose E. Marchesi
     [not found] <1490721669-12560-1-git-send-email-vladimir.mezentsev@oracle.com>
     [not found] ` <5a3397ae-e986-8a36-13ba-ed2cfeb68a12@redhat.com>
2017-03-29 16:38   ` Vladimir Mezentsev
2017-04-18 14:54     ` Pedro Alves
  -- strict thread matches above, loose matches on Subject: below --
2017-03-29 16:21 vladimir.mezentsev
2017-04-18 14:54 ` Pedro Alves
2017-04-18 21:28   ` Jose E. Marchesi
2017-04-18 22:20     ` Pedro Alves
2017-04-19  9:01       ` Jose E. Marchesi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6e9de3d-57cf-2dd9-08d9-0c87779c739d@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jose.marchesi@oracle.com \
    --cc=vladimir.mezentsev@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox