From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 662E7386186A
 for <gdb-patches@sourceware.org>; Mon,  7 Sep 2020 18:47:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 662E7386186A
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 091781E509;
 Mon,  7 Sep 2020 14:47:14 -0400 (EDT)
Subject: Re: [PATCH v2 04/10] Add netbsd_nat::pid_to_exec_file
To: Kamil Rytarowski <n54@gmx.com>, gdb-patches@sourceware.org
Cc: tom@tromey.com
References: <20200904002905.13616-1-n54@gmx.com>
 <20200904002905.13616-5-n54@gmx.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <a6d319a7-2103-0bf4-41ed-e8fc73d81a1f@simark.ca>
Date: Mon, 7 Sep 2020 14:47:13 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200904002905.13616-5-n54@gmx.com>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Sep 2020 18:47:15 -0000

On 2020-09-03 8:28 p.m., Kamil Rytarowski wrote:
> gdb/ChangeLog:
> 
>         * netbsd-nat.h: Include <unistd.h>.
>         * (netbsd_nat::pid_to_exec_file): Add.
>         * netbsd-nat.c: Include <sys/types.h> and <sys/sysctl.h>.
>         * (netbsd_nat::pid_to_exec_file) Add.
> ---
>  gdb/ChangeLog        |  7 +++++++
>  gdb/nat/netbsd-nat.c | 18 ++++++++++++++++++
>  gdb/nat/netbsd-nat.h |  5 +++++
>  3 files changed, 30 insertions(+)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 9e9d4e16e5d..335d6b7271f 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,10 @@
> +2020-09-04  Kamil Rytarowski  <n54@gmx.com>
> +
> +	* netbsd-nat.h: Include <unistd.h>.
> +	* (netbsd_nat::pid_to_exec_file): Add.
> +	* netbsd-nat.c: Include <sys/types.h> and <sys/sysctl.h>.
> +	* (netbsd_nat::pid_to_exec_file) Add.
> +
>  2020-09-04  Kamil Rytarowski  <n54@gmx.com>
> 
>  	* configure.nat (NATDEPFILES): Add nat/netbsd-nat.o when needed.
> diff --git a/gdb/nat/netbsd-nat.c b/gdb/nat/netbsd-nat.c
> index 2b5a4183e30..297188bb8b4 100644
> --- a/gdb/nat/netbsd-nat.c
> +++ b/gdb/nat/netbsd-nat.c
> @@ -19,6 +19,24 @@
> 
>  #include "nat/netbsd-nat.h"
> 
> +#include <sys/types.h>
> +#include <sys/sysctl.h>
> +
>  namespace netbsd_nat
>  {
> +
> +/* Return the executable file name of a process specified by PID.  Returns the
> +   string in a static buffer.  */
> +
> +char *

Since there's no reason for the caller to modify this string, I'd suggest returning `const char *`.

> +pid_to_exec_file (pid_t pid)
> +{
> +  static char buf[PATH_MAX];
> +  int mib[4] = {CTL_KERN, KERN_PROC_ARGS, pid, KERN_PROC_PATHNAME};
> +  size_t buflen = sizeof (buf);
> +  if (::sysctl (mib, ARRAY_SIZE (mib), buf, &buflen, NULL, 0))
> +    return NULL;

!= 0

Simon