From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34832 invoked by alias); 12 Jan 2017 16:40:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34812 invoked by uid 89); 12 Jan 2017 16:40:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jan 2017 16:40:34 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 921D9C04B926; Thu, 12 Jan 2017 16:40:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0CGeX9r020197; Thu, 12 Jan 2017 11:40:33 -0500 Subject: Re: [PATCH 8/8] Don't throw exception in dis_asm_memory_error To: Yao Qi , binutils@sourceware.org, gdb-patches@sourceware.org References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484051178-16013-9-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Thu, 12 Jan 2017 16:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1484051178-16013-9-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00245.txt.bz2 On 01/10/2017 12:26 PM, Yao Qi wrote: > --- a/gdb/testsuite/gdb.base/all-architectures.exp.in > +++ b/gdb/testsuite/gdb.base/all-architectures.exp.in > @@ -152,6 +152,9 @@ proc print_floats {} { > > proc do_arch_tests {} { > print_floats > + > + gdb_test_internal "disassemble 0x0,+4" \ > + "Cannot access memory at address 0x0" > } This will fail if you're testing against a non-MMU target, where you can read address 0. Check is_address_zero_readable? Thanks, Pedro Alves