From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 540AD3898530 for ; Thu, 30 Apr 2020 17:01:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 540AD3898530 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9C64EABC7; Thu, 30 Apr 2020 17:01:18 +0000 (UTC) Subject: Re: Recent commit in binutils-gdb To: Andrew Burgess Cc: Sterling Augustine , Eric Christopher , gdb-patches , Simon Marchi References: <41d74a1a-0748-4a40-6365-011ac0c2a2ff@polymtl.ca> <725b0ecd-7cfe-b93e-f9c8-953fca8c2502@suse.de> <20200430132427.GM3522@embecosm.com> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: Date: Thu, 30 Apr 2020 19:01:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200430132427.GM3522@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-15.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2020 17:01:30 -0000 On 30-04-2020 15:24, Andrew Burgess wrote: > * Tom de Vries [2020-04-30 07:49:56 +0200]: > >> On 30-04-2020 06:10, Sterling Augustine via Gdb-patches wrote: >>> The commit was proposed here: >>> >>> https://sourceware.org/pipermail/gdb/2020-March/000012.html >>> >> >> With reproducer: >> ... >> $ cat b.cpp >> namespace hide { struct Bar { int y; }; } >> struct Foo { hide::Bar* b; }; >> >> inline void x() { hide::Bar b; } >> >> static Foo aFoo; >> >> void * f() { >> return aFoo.b; >> } >> >> int main() { >> f(); >> return 0; >> } >> $ g++ -fdebug-types-section b.cpp -g >> $ ./build/gdb/gdb -ex "b f" -ex run -ex "ptype hide::Bar" ./a.out >> ... >> >> I can reproduce this problem before the recent commit 770479f223e "gdb: >> Fix toplevel types with -fdebug-types-section", but not after. >> >> Also, when I revert commit 770479f223e, and leave this one in place, it >> doesn't fix the problem. That seems to be because the proposed commit: >> ... >> @@ -10954,6 +10954,7 @@ dwarf2_cu::setup_type_unit_groups (struct >> die_info *die) >> compunit_language (cust), >> 0, cust)); >> >> + list_in_scope = get_builder ()->get_file_symbols (); >> auto &file_names = line_header->file_names (); >> for (i = 0; i < file_names.size (); ++i) >> { >> ... >> and the actual commit differ (note the different in context before): >> ... >> @@ -10942,6 +10942,7 @@ dwarf2_cu::setup_type_unit_groups (struct >> die_info *die) >> = XOBNEWVEC (&COMPUNIT_OBJFILE (cust)->objfile_obstack, >> struct symtab *, line_header->file_names_size ()); >> >> + list_in_scope = get_builder ()->get_file_symbols (); >> auto &file_names = line_header->file_names (); >> for (i = 0; i < file_names.size (); ++i) >> { >> ... >> >> In summary, the problem was fixed by an earlier commit, and this commit >> was misapplied. I think we should probably revert this one. > > FWIW I agree. Andrew, thanks for the input, I've now reverted the patch. Guys, my apologies for how this went. A patch for this problem was approved in Januari, but lingered around uncommitted, leading to duplicated work. We'll try to do better. Thanks, - Tom