From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/6] Cast to bfd_vma in arm-tdep.c
Date: Tue, 10 Mar 2020 23:38:06 -0400 [thread overview]
Message-ID: <a5f18235-6969-d756-a3e7-ecb3f562f8d8@simark.ca> (raw)
In-Reply-To: <20200225222243.8260-4-tom@tromey.com>
On 2020-02-25 5:22 p.m., Tom Tromey wrote:
> Some arm-tdep.c data structures use a bfd_vma. A couple of spots will
> warn about an implicit narrowing cast when building a gdb where
> CORE_ADDR is 64-bit but bfd_vma is 32-bit.
>
> This patch silences these warnings by introducing an explicit cast.
> This seemed both simplest and correct.
Did you consider changing arm_mapping_symbol::value to be a CORE_ADDR? It would
seem even simpler and safe to me.
Simon
next prev parent reply other threads:[~2020-03-11 3:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 22:22 [PATCH v2 0/6] Change gdbserver to use existing gdbsupport Tom Tromey
2020-02-25 22:22 ` [PATCH v2 3/6] Cast to bfd_vma in arm-tdep.c Tom Tromey
2020-03-11 3:38 ` Simon Marchi [this message]
2020-03-12 17:58 ` Tom Tromey
2020-03-12 18:05 ` Simon Marchi
2020-03-12 19:35 ` Tom Tromey
2020-02-25 22:22 ` [PATCH v2 2/6] Don't use sprintf_vma for CORE_ADDR Tom Tromey
2020-02-25 22:22 ` [PATCH v2 4/6] Fix gdbserver build when intl already built Tom Tromey
2020-02-25 22:22 ` [PATCH v2 5/6] Change gdbsupport not to rely on BFD Tom Tromey
2020-02-25 22:22 ` [PATCH v2 1/6] Fix CORE_ADDR size assertion in symfile-mem.c Tom Tromey
2020-02-25 22:22 ` [PATCH v2 6/6] Change gdbserver to use existing gdbsupport Tom Tromey
2020-03-11 0:30 ` [PATCH v2 0/6] " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f18235-6969-d756-a3e7-ecb3f562f8d8@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox