From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129089 invoked by alias); 8 Jul 2018 16:35:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129065 invoked by uid 89); 8 Jul 2018 16:35:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=editors, pasted X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:35:28 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 343E01E059; Sun, 8 Jul 2018 12:35:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531067727; bh=xU02Htj6ry1pMDqBXbUAaBN5pp1tsG6XpmLB6Kd0qI4=; h=Subject:To:References:From:Date:In-Reply-To:From; b=FjQGSOqZaACNd3nLlUeCg4sBk0BU5u2moIeQhdqwlJNjojc1ctf6doU3x/FpZh+8x 6EImsijnQD/dldAsOTFOrO6YDeg9V6n0QNpRY6XeWZBuZKDuqzgC6MAwPPd3Kinc1T nzJnbN6KprSiOtTEiQT5Gfug+fkZeFTemDf4AqoI= Subject: Re: [RFA 10/42] Move some code from buildsym to stabsread To: Keith Seitz , Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-11-tom@tromey.com> <99fce463-478c-de06-b2f0-081e3c18fed8@redhat.com> From: Simon Marchi Message-ID: Date: Sun, 08 Jul 2018 16:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <99fce463-478c-de06-b2f0-081e3c18fed8@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00189.txt.bz2 On 2018-07-05 03:16 PM, Keith Seitz wrote: > I just have one comment: > > On 05/22/2018 09:58 PM, Tom Tromey wrote: >> diff --git a/gdb/stabsread.c b/gdb/stabsread.c >> index 4cfefaa3e0..13663106dc 100644 >> --- a/gdb/stabsread.c >> +++ b/gdb/stabsread.c >> @@ -44,6 +44,7 @@ >> #include "target-float.h" >> #include "cp-abi.h" >> #include "cp-support.h" >> +#include "bcache.h" >> #include >> >> /* Ask stabsread.h to define the vars it normally declares `extern'. */ >> @@ -4839,6 +4840,18 @@ find_name_end (const char *name) >> } >> } >> >> + >> + >> +/* Compute a small integer hash code for the given name. */ >> + >> +int >> +hashname (const char *name) >> +{ >> + return hash (name, strlen (name)) % HASHSIZE; >> +} >> + >> + >> + >> /* Initializer for this module. */ >> >> void > > Seems some superfluous newlines got pasted in here? The newline in the middle is actually a form feed character, as recommended in the GNU coding standards [1]: "Please use formfeed characters (control-L) to divide the program into pages at logical places (but not within a function). It does not matter just how long the pages are, since they do not have to fit on a printed page. The formfeeds should appear alone on lines by themselves." I'd be really curious to know if anybody cares about them today. I know in some editors you can jump from on to the other. In my editor, they just appear as the little "special character" box with the ascii/unicode in it. [1] https://www.gnu.org/prep/standards/html_node/Formatting.html > Please use "See stabsread.h" and move the comment into the header. > > Okay, that's actually two comments, but one is so trivial, I didn't count it. > > Keith > LGTM with Keith's comment about the comment addressed. Simon